Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error on skill Abracadrabra/Hocus-Pocus (SA_ABRACADABRA) #2824

Closed
Tracked by #2859
haarenas opened this issue Aug 30, 2020 · 0 comments
Closed
Tracked by #2859

Error on skill Abracadrabra/Hocus-Pocus (SA_ABRACADABRA) #2824

haarenas opened this issue Aug 30, 2020 · 0 comments
Assignees
@dastgirp
Milestone
Release v2021.04.05

Comments

@haarenas
Copy link

Describe the bug
When you use the skill (that is not learned by the sage) and try to select a target or ground (depending on the randomized spell) the skill generated isn't casted (It doesnt generate any error on console log)

To Reproduce

  1. Login with a Sage Class.
  2. Use the skill Abracadabra.
  3. Try execute a skill that you dont have learned and it will fail.

Expected behavior
It should be cast any of the randomized spells.

System specs (please complete the following information):

  • OS: Windows 10 Pro 64bit, version 1903.
  • Hercules Version: v2020.08.23
  • Mode: Renewal
  • Packet version: 20180620
  • Client type: RE

Plugins used or source modifications
No modifications.

Aditional Note
Possibly the origin of problem is the same as #2823
dastgirp added a commit to dastgirp/Hercules that referenced this issue Oct 2, 2020
@dastgirp
Fixes Abracadabra and Improvised Skill
df3fa27 
The Autocast by abra was cleared before the actual casting, which resulted in failure of skill if not learned.

Fixes HerculesWS#2823
Fixes HerculesWS#2824
@dastgirp dastgirp mentioned this issue Oct 2, 2020
Closed
5 tasks
@dastgirp dastgirp self-assigned this Oct 2, 2020
MishimaHaruna added a commit to MishimaHaruna/Hercules that referenced this issue Apr 6, 2021
@MishimaHaruna
Fix Abracadabra / Improvise / itemskill validation
281683c 
This commit introduces various fixes to the Abracadabra / Improvise
skill validation:

- autocast code is moved to after homun/merc skill ranges so that when
  any of those are triggered, autocast data is not purged
- abracadabra/improvise is no longer purged immediately after cast, by
  calling autocast_clear_current in the proper manner
- the abracadabra/improvise skill requirement bypass that was removed in
  HerculesWS#2657 and related pull requests is re-implemented
- the condition that would get the character stuck and unable to cast
  other skills until teleporting or relogging when rolling AL_WARP from
  abracadabra (i.e. because AL_WARP lands in clif_parse_UseSkillMap in 2
  steps) is fixed, by not immediately clearing the data after the first
  one

All credits for the fix go to Heka of Origins

Related to HerculesWS#2859
Fixes HerculesWS#2823
Fixes HerculesWS#2824

Signed-off-by: Haru <[email protected]>
@MishimaHaruna MishimaHaruna mentioned this issue Apr 6, 2021
Merged
3 tasks
@MishimaHaruna MishimaHaruna added this to the Release v2021.04.05 milestone Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dastgirp dastgirp

Labels
None yet
Projects
None yet
Milestone
Release v2021.04.05
Development

No branches or pull requests
3 participants
@dastgirp @MishimaHaruna @haarenas