This repository has been archived by the owner on Mar 20, 2020. It is now read-only.
feat: switch window for self for webworker compatibility #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
daviddias
approved these changes
Mar 17, 2017
|
@fippo, @HenrikJoreteg can we get this one merged? I can also create another module following your suggestion here, but I would rather than have one utility rather than two to achieve the same goal. |
daviddias
approved these changes
May 16, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
selfis a safer and more portable reference to global context thanwindow, with virtually the same browser version/history support. Usingselfshould allow detecting webrtc capabilities with this library in web/serviceworker environments without breaking.Fixing this would also allow running IPFS in webworkers.
For background, here are a few pointers:
eslint/eslint#8229
ipfs/js-ipfs#725
ipfs/js-ipfs#728