Add support for several different NODE_ENV values #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for using different NODE_ENV values than "production" when running the `DefinePlugin`. It now sets `NODE_ENV` to whatever the environment variable `NODE_ENV` is, and defaults to "production" if `NODE_ENV` is not set. Fixes #328.
selbekk
requested review from
HenrikJoreteg,
sansthesis,
lukekarrys,
dignifiedquire and
FWeinb
lukekarrys
approved these changes
Apr 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for using different NODE_ENV values than
"production" when running the
DefinePlugin. It now setsNODE_ENVto whatever the environment variable
NODE_ENVis, and defaults to"production" if
NODE_ENVis not set.Fixes #328.