-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Quest: trail_visibility #486
New Quest: trail_visibility #486
Conversation
For discussion:
|
I wouldn't add them. If they're man made, with those surfaces it's always going to be Maybe Anyway users of SCEE can expand the query for themselves as needed, so it is OK as is, IMHO.
That would make it painful to scroll, probably. I'm however hoping that perhaps better images could be found / taken. That |
app/src/main/java/de/westnordost/streetcomplete/quests/trail_visibility/AddTrailVisibility.kt
Show resolved
Hide resolved
(FYI @mcliquid I've changed PR text to say "fixes #478" instead of "fix for #478", to use magic keyword which automatically resolves the issue when PR gets merged) |
I agree on this, the images are not particularly helpful for me. |
Hm, should we remove the images and go with a text only quest form? |
I agree finding good images would be very hard if possible at all. The texts for |
Another user suggested alternative images here, are these possibly more suitable?
Here would be the quest without pictures, only with text. No idea why the last two entries are indented.
I've added "no markers" to all other items. |
@Helium314 Can you guide me how to solve the merge conflict with the strings_ee.xml file? |
fixed it |
@Helium314 What do you think, ready to merge? |
Quest looks fine now. |
Removed all images and tested the app successfully. |
I found some minor things when testing, will add comments to the code |
app/src/main/java/de/westnordost/streetcomplete/quests/trail_visibility/TrailVisibility.kt
Outdated
Show resolved
Hide resolved
...rc/main/java/de/westnordost/streetcomplete/quests/trail_visibility/AddTrailVisibilityForm.kt
Show resolved
Hide resolved
svg reduced from from 19KB to 12KB
Fixes #478