-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add map_type and map_size quests #482
Conversation
Nice quests!
This would make the Quest much more recognizable?
For me, pictures would be much quicker to recognize for a decision. |
Added quest icons. |
The wiki doesn't really provide images we could use. I would need to find some examples myself if the images are deemed neccecary for merge of this PR. |
Just as a heads-up, after adding the icons, the app builds succesfully but crashes on startup. I have no idea how I did this since I only added the icons, but I would not consider this PR "tested" anymore. |
I think for
It doesn't look like there is an error in your last commit. What does the log say? |
Okay, I'll be on the hunt for some example pictures.
I found the problem. When pulling the latest version from upstream, a new quest with the same ordinal I used was pulled in. Fixed that. |
One image was taken from the OSM Wiki and is licensed under CC-BY. Do we have a file where we name the authors in SCEE? |
Here you go: https://github.com/Helium314/SCEE/blob/modified/app/src/main/res/authors.txt I would suggest this one for the toposcope image: https://commons.wikimedia.org/wiki/File:Melshornet03112006GunnarHeltne.jpg
I've added some missing ones here: https://wiki.openstreetmap.org/wiki/Tag:information%3Dmap |
Oh theese are way better than mine! I think I'll use them. |
Images replaced and licenses added. |
I did not yet test it, but some comments:
|
app/src/main/java/de/westnordost/streetcomplete/quests/map/AddMapTypeForm.kt
Show resolved
Hide resolved
Everything done. |
This PR adds two quests:
The values are taken from the wiki pages.
Would like thoughts/comments on the following things:
board_type
icon okay?