-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Street cabinet quest #470
Conversation
…at it is not signed
See this JOSM preset for translations and values: https://josm.openstreetmap.de/wiki/Presets/StreetCabinet |
@Helium314 I'm not really happy with the icon - nevertheless you could do the code review. The icon should have grey background to match the others service type quests. But a grey street cabinet on a grey background looks strange. Will have a second look later. |
...rc/main/java/de/westnordost/streetcomplete/quests/street_cabinet/AddStreetCabinetTypeForm.kt
Outdated
Show resolved
Hide resolved
Strange, the filter looks ok at first glance. There is no need for the parentheses, but that should not change anything... I'll have time for a closer look tomorrow |
@Helium314 When you create a new POI (street cabinet) it's working: |
For me it always highlights nearby street cabinets, don't know why it doesn't / didn't work for you. I finally had a look at the quest, and I think the list looks pretty long... some other form would be better here, maybe |
remove commas inside when import de.westnordost.streetcomplete.quests.street_cabinet.StreetCabinetType.* remove not needed sealed interface StreetCabinetTypeAnswer
Thanks for your help! |
I've added some improvements to the UI - from my side this one is ready 👍 |
The UI looks good, but the icons on the street cabintes are a little small. Does it still look ok if you make the icons larger and move them to the center of the street cabinet (maybe remove the handle)? street_cabinet_power.xml seems unused |
Looks a little weird in full size view of Android Studio, but works great on the phone, thanks! |
Strings |
Yes, you're right - removed them! |
Related StreetComplete issues:
streetcomplete#4505
streetcomplete#3157