POI update (delete or not delete other tags)

[Filip10]

I remember, that when I was changing the object, app asked me about "if it is still the same thing" but now it is not asking me and I don't know what I have changed.

[mnalis]

There is somewhat complicated logic behind when that is asked:

SCEE/app/src/main/java/de/westnordost/streetcomplete/overlays/places/PlacesOverlayForm.kt

Lines 271 to 298 in a504308

	val shouldNotReplaceShop =
	// only a name was added (name was missing before; user wouldn't be able to answer
	// if the place changed or not anyway, so rather keep previous information)
	hasAddedNames && !hasChangedFeature
	// previously: only the feature was changed, the non-empty name did not change
	// - see #5195
	// place has been added, nothing to replace
	|| element == null
	val shouldAlwaysReplaceShop =
	// the feature is or was a brand feature (i.e. overwrites the name)
	isFeatureWithName || wasFeatureWithName
	// was vacant before but not anymore (-> cleans up any previous tags that may be
	// associated with the old place)
	|| wasVacant && hasChangedFeature
	// it's vacant now
	|| isVacant
	val doReplaceShop =
	if (shouldNotReplaceShop) {
	false
	} else if (shouldAlwaysReplaceShop) {
	true
	} else {
	// ask whether it is still the same shop if:
	// + the name was changed
	// + the feature was changed and the name was empty before
	confirmReplaceShop()
	}

but basically, in most cases it will get asked "if it is still the same thing" in Places Overlay if:

• you change only the name (but type of the place remain the same), or
• place had no name before, and you changed type of the place

[Filip10]

Because I'm changing some POI's, which are included in Name Suggestion Index, and when I change some just to add operator:wikidata and operator, it is also deleting opening_hours and other tags, which is not what I want. I just tested it out with name or place type change and question "if it is still the same thing" was not asked.

[mnalis]

Thanks for clarifying, that is indeed unfortunate! Given that the issue is the same in upstream StreetComplete, I've made an enhancement request there to improve that use case, so you may want to subscribe/like there: streetcomplete#5940

[Filip10]

Thank you :)