update changelog and comments

Helium314 · Feb 10, 2023 · 249b0d4 · 249b0d4
1 parent ba94523
commit 249b0d4
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 2 deletions.
diff --git a/app/build.gradle.kts b/app/build.gradle.kts
@@ -192,7 +192,7 @@ dependencies {
     implementation("com.github.chrisbanes:PhotoView:2.3.0")
 
     // faster sqlite library (additional capabilities like R*-tree or json1 not used)
-    // performance comparison: https://github.com/streetcomplete/StreetComplete/issues/3609#issuecomment-1031177576
+    // putting 25% faster, reading 5% faster than Android 9 built-in sqlite
     implementation("com.github.requery:sqlite-android:3.39.2")
     implementation("androidx.sqlite:sqlite:2.3.0")
 

diff --git a/app/src/main/java/de/westnordost/streetcomplete/data/osm/mapdata/NodeDao.kt b/app/src/main/java/de/westnordost/streetcomplete/data/osm/mapdata/NodeDao.kt
@@ -97,6 +97,8 @@ private val jsonAdapter: JsonAdapter<Map<String, String>> = Moshi.Builder().buil
 private fun CursorPosition.toNode() = Node(
     getLong(ID),
     LatLon(getDouble(LATITUDE), getDouble(LONGITUDE)),
+    // copying from the moshi-"LinkedTreeHashMap" to a normal HashMap is slightly slower than keeping
+    // the moshi map, but tag search then is a little faster, so overall it's better, plus using less memory
     getStringOrNull(TAGS)?.let { jsonAdapter.fromJson(it)?.let { HashMap<String, String>(it.size, 1.0f).apply { putAll(it) } } } ?: emptyMap(),
     getInt(VERSION),
     getLong(TIMESTAMP),

diff --git a/app/src/main/res/raw/changelog_ee.yml b/app/src/main/res/raw/changelog_ee.yml
@@ -13,6 +13,7 @@
   <li>Add artwork type quest</li>
   <li>Add railway platform ref quest</li>
   <li>Allow showing direction of highlighted way</li>
+  <li>Add log reader</li>
   <li>Other small fixes and improvements</li>
   <li>Dangerous editing capabilities (compared to normal SC) are now hidden unless an "expert mode" setting is enabled</li>
   </ul>

diff --git a/metadata/en-US/changelogs/5100.txt → metadata/en-US/changelogs/5101.txt b/metadata/en-US/changelogs/5100.txt → metadata/en-US/changelogs/5101.txt
@@ -2,9 +2,10 @@
 - Understand left/right/both in custom overlay coloring
 - Allow saving full photos used for notes
 - Add level when creating POI while level filter is active
-- Allow importing / exporting custom overlay separately
+- Import / export custom overlay
 - Delete button in tag editor deletes row on long press
 - Allow deleting nodes in overlays
+- Improve healthcare UI
 - "External quest" renamed to "Custom quest"
 - Add artwork type and railway platform ref quests
 - Allow showing direction of highlighted way