Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend existing superscript symbols on popup keys #902

Merged
merged 5 commits into from
Jun 30, 2024

Conversation

b02860de585071a2
Copy link
Contributor

I have built and tested this on both an emulator and a physical Pixel 8 Pro, using standard EN-US QWERTY layout and Spanish QWERTY (with ñ, unsure of the technical name?).

Due to the minor nature of this change, I doubt it will introduce any complications, but further testing on lesser-used layouts is likely still needed.

@Helium314
Copy link
Owner

I'm ok with the number row changes, but the other keys seem to be more suitable for symbols_shifted than for symbols, or at very least should not be the first popup.

@b02860de585071a2
Copy link
Contributor Author

the other keys seem to be more suitable for symbols_shifted than for symbols

is actually supposed to be in symbols_shifted, I just stuck it on the wrong key.

730d9e9 should now preserve default popup key orders as shown below:

Current stable version screenshots

Screenshot_20240629-191438_Nova Launcher
Screenshot_20240629-191418_Nova Launcher
Screenshot_20240629-191406_Nova Launcher
Screenshot_20240629-191350_Nova Launcher
Screenshot_20240629-191335_Nova Launcher

730d9e9 screenshots

Screenshot_20240629-191808_Nova Launcher
Screenshot_20240629-191755_Nova Launcher
Screenshot_20240629-191736_Nova Launcher
Screenshot_20240629-191722_Nova Launcher
Screenshot_20240629-191706_Nova Launcher

This also keeps the grouping much more consistent with defaults (paren is now on the outside of the other types of brackets, etc). Let me know your thoughts.

@Helium314
Copy link
Owner

Thanks, this look fine.

@Helium314 Helium314 merged commit 2150b39 into Helium314:main Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PR] Extend existing superscript symbols on popup keys
2 participants