toast notifications

[codokie]

This PR adds toast notifications.

In Android 12L and below, there is no need for notification permission (which Heliboard currently does not have), so the toasts will be displayed natively.

For newer Android versions, a "fake" toast will be shown instead. Here's how it would look (inspired by OneUI):

It has a 300ms fade in/out animation to make the transition smoother. The view does not prevent pressing the keys it covers.

In Android versions older than 13, a toast notification will now be shown for 2 seconds when content is copied to the clipboard (can be triggered by pressing the copy/cut toolbar keys).
In Android 13+, most devices already show some kind of notification whenever the clipboard is set, so there is no need to display another one.

However, it will be possible to use it for other purposes like indicating an image URI could not be pasted to an input field (#722), or that the clipboard history has been cleared (#679). If you have any other ideas please let me know.

Fixes #545

[Helium314]

Not sure whether it works, but having the fake toast in default device style is worth trying. Could you try making a Toast without showing it on Android 13+ and extract the background drawable and text color?
According to https://stackoverflow.com/a/9432923 Toast.getView() should contain a TextView accessible via TextView v = (TextView) toast.getView().findViewById(android.R.id.message);
Then you could get background and text color using v.getBackground() and v.getCurrentTextColor().

[codokie]

Toast.getView() should contain a TextView accessible via TextView v = (TextView) toast.getView().findViewById(android.R.id.message);

I don't think this still works, I tried to get the view and got:

java.lang.NullPointerException: Attempt to invoke virtual method 'android.view.View android.view.View.findViewById(int)' on a null object reference'

The comment here may be the reason for it

[Uranusek]

Shouldn't this notification be a little lower? 🤔 Most often I saw them just above the spacebar.

[codokie]

I think you might be right, but there may be a better placement for this notification:

In OneUI 6 (android 14) the toast notification when copying something to the clipboard are actually above the keyboard, right in the middle of the screen:

That makes the toast less intrusive as it does not hide keys on the keyboard

[Uranusek]

It looks better than on the keyboard, but I think that for some people such a notification in the middle of the screen can be annoying. Maybe it's better to place it just above the keyboard?

[codokie]

Just above the keyboard would probably over input fields because they have a tendency to be just above the keyboard too (and below the center of the screen).
Like here for instance (screenshot taken from Messages app):

[Helium314]

I find the position somewhat awkward comparing to normal toast messages, but showing some amount above the keyboard definitely is a good idea, as this is a. not covering the text field (assuming it's a single line), and b. not at a place that might be covered with fingers.

The inability to copy the system toast style is unfortunate. Though maybe we could derive toast colors from the keyboard colors...

[Helium314]

@codokie do you plan to move the notification to the place above the input field, or do you consider this PR done?

[codokie]

I think such change would make the toast notifications less obstructive for the user, so it may be worth trying to implement it.

I'm a newbie still when it comes to xml layouts, I tried to change things around in main_keyboard_frame.xml to no avail, perhaps you are aware of another approach that might work?

The idea is to place the toast's TextView directly in the middle of the screen, I don't think it's possible to tell where the input field is actually placed

[Helium314]

I think it might work when you do it in input_view.xml.
But this might also end up increasing size of the input view, which would be bad. If that doesn't work out, I'll have a look later.

[codokie]

Thanks, input_view.xml seems to do the trick!

The only thing that may be missing is a mini-sized icon of Heliboard to the left of the icon message, so people would be able to tell the notification is coming from the HeliBoard app, like in a real toast:

I believe this should be pretty easy to add, perhaps later today

[Helium314]

You could try something like android:drawableLeft="@drawable/ic_launcher_round" in the TextView.

[Helium314]

like in a real toast

This is highly dependent on the Android version though, device manufacturers may style the toast, and some custom roms also do this, or let the user tune the toast.
I just want to say that sticking to specific style is not necessary, as it cannot fit with toast style of all devices.

[codokie]

You are right there is no standard toast, it's a shame we can't use the system toast view without the notification permission..
That said, the icon is useful for figuring out where the toast message is coming from, so it's more than a style choice.

With the new changes our "fake" toast looks like this:

In my samsung device this style seems natural, I hope it would not look really out of place in other ROMs

[Helium314]

Having the message centered may be a (minor) issue in some cases. E.g. in landscape mode it will be on the keyboard, or when height scale is very low it will be far above the keyboard. But handling the window insets is probably too much, at least in scope of this PR.

[Helium314]

For me, the toast is hidden behind the more suggestions panel. Is it the same for you?

[codokie]

I just checked and it is also hidden for me
There should be some way to make the toast view appear on top
Alternatively another 'ugly workaround' would be to dismiss the more suggestions panel just before the toast would get shown
In landscape mode the fake toast isn't shown even when the panel is dismissed, but mFakeToast.bringToFront() seems to solve that

[Helium314]

I don't really like the way how some parts of the toast are being handled though.

1. When showToast is called, it should really show a toast; the fallback thing is out of place. When it should actually not show the toast_msg_clipboard_copy toast, then just don't call showToast (have that logic in copyText)
2. I don't think showToast should be in LatinIME, KeyboardSwitcher already has a relevant part of that code. Then you could also call it using KeyboardSwitcher.getInstance().showToast

[Helium314]

Does that reproduce the toast on your system? For me the default toast is much faster than that.

[codokie]

You mean that the animation of the system toast is faster? because in terms of timing I haven't noticed a real difference

[codokie]

1. I opted for the fallback argument to just so there wouldn't be a need to check the build version in RichInputConnection, but yeah besides that it isn't very useful so it can be removed
2. Sounds fair, I did not know you could get an instance of KeyboardSwitcher. I'll remove the code from LatinIME