Updating text for middle suggestion settings #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just for your information (@codokie unfortunately already knows how it is...): I don't have enough time recently, and instead of getting better it seems to be getting worse 😐 |
Helium314
reviewed
Apr 30, 2024
| // make sure typed word is shown, so user is able to override incoming autocorrection | ||
| // If there is an incoming autocorrection, make sure typed word is shown, so user is able to override it. | ||
| // Otherwise, if the relevant setting is enabled, show the typed word in the middle. | ||
| val typedIndex = if (hasAutoCorrection) 2 else 1 |
There was a problem hiding this comment.
typedIndex is a confusing name, please be more explicit (e.g. indexOfTypedWord)
Helium314
reviewed
Apr 30, 2024
| @@ -87,6 +87,7 @@ public final class Settings implements SharedPreferences.OnSharedPreferenceChang | |||
| public static final String PREF_AUTO_CORRECTION = "auto_correction"; | |||
| public static final String PREF_MORE_AUTO_CORRECTION = "more_auto_correction"; | |||
| public static final String PREF_AUTO_CORRECTION_CONFIDENCE = "auto_correction_confidence"; | |||
| public static final String PREF_CENTER_SUGGESTION_TEXT_TO_COMMIT = "center_suggestion_text_to_commit"; | |||
There was a problem hiding this comment.
Could you adapt the setting name for the changed wording?
|
Hey I noticed that it fails to compile: Could you replace |
|
Hey just fixed and pushed the change. Sorry about that. Is that going to need a new PR? |
|
I'll do the fix myself, don't worry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing PR #672