do not coerce non-text clipboard content #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal clipboard history adds all clipboard mime types even if it is non-text (like an image media type), and that causes the keyboard to freeze for a few moments before the history view is opened after copying an image to the clipboard, especially noticeable if the image is hi-res.
Reproducible at least in recent OneUI versions which have the "Copy to clipboard" context menu in the Gallery app
Until clipboard images are supported, there is no need to coerce mime types that are not text.
Shoutout to @RHJihan for noticing this bug