Remove unused keys for Romanian

[clmbmb]

Remove extra keys/characters that are not used in Romanian language. The extra keys are only getting in the way when trying to use the native Romanian diacritics.

fixes #921

[Helium314]

This is changing something that has been there for more than 10 years, and in my opinion should be handled more carefully since users quite possibly got used to it.
I don't remember this being requested anywhere, but if such a change is to be made, it should be done consistently for all languages (maybe limited to latin alphabet).

[clmbmb]

This is changing something that has been there for more than 10 years, and in my opinion should be handled more carefully since users quite possibly got used to it. I don't remember this being requested anywhere, but if such a change is to be made, it should be done consistently for all languages (maybe limited to latin alphabet).

Romanian language only has these diacritics: Ăă, Ââ, Îî, Șș, Țț. Having the extra characters on the keys is pretty disorienting (at first) and redundant. I've used other (non-open source) keyboards on Android and most of them had only these characters (plus the € sign) on their keys.

I don't know how many Romanian people are using Heliboard at the moment, but it would be a good thing to ask the community about this change.

[Helium314]

I see your point... I would like to do this consistently, i.e. together with removing such keys for other languages too.
And maybe at the same time tweak what is shown when using the "Show more letters with diacritics in popup" setting.

It may take me a while for me though, just to be sure I don't accidentally remove the wrong popup keys for some language (and maybe need to consider common but foreign characters like in café).

[clmbmb]

I totally agree with your suggestion. And there's no hurry in fact. You have more important things to fix/implement. Thanks for your work!

[tenextractor]

Here is my suggestion:

Ă Â Î Ș Ț are fully separate letters in Romanian but the current keyboard does not have separate keys for them. The method of long pressing keys makes typing too slow on an already slow mobile keyboard. For example to type the word 'română' you would have to press r, o, m, long press a and select â, press n, long press a and select ă. To type a single word you would have to long press twice. This is makes typing very slow.

So I recommend giving Ă Â Î Ș Ț separate keys as follows:

Q W E R T Y U I O P Ă
A S D F G H J K L Ș Ț
⬆ Z X C V B N M Î Â ⬅

Using this as the layout means that popup keys for letters in other languages (like Ö etc.) need not be removed

[Helium314]

This looks like a potentially useful source for letters by (latin) language: https://altcodeunicode.com/alt-codes-for-latin-letters-with-accents-or-diacritical-marks-used-in-foreign-languages/

Does it look ok for Romanian? I noticed there is an additional version of s included.

[tenextractor]

The extra ones were wrongly included in an old keyboard layout, Ș (U+0218) and Ț (U+021A) are the correct and official letters.

The best source about alphabets for me has been Wikipedia.

[Helium314]

@clmbmb would it be ok for you if I use this PR to (maybe a little slowly) do the same adjustments for other latin locales, so everything can be merged at once?

[clmbmb]

@clmbmb would it be ok for you if I use this PR to (maybe a little slowly) do the same adjustments for other latin locales, so everything can be merged at once?

Yes, it's totally OK.

Also, I agree with @tenextractor on the comment above.

[Helium314]

Below there is a list of all files in locale_key_texts that use latin script.
Languages where no work is needed any more are marked.

az
ca
cs
da
de
de-CH
de-DE
en
eo
es
et
eu
fi
fr
gl
hi-Latn
hr
hu
is
it
lt
lv
nb
nl
pl
pms
pt
rm (unused, removed in main)
ro
sk
sl
sr-Latn
sv
sw
tl
tr
vi
zu
(zz)

[Helium314]

Ugh, I thought GitHub would now let me merge upsteam conveniently.