Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: sign data #88

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

hai-kreate
Copy link
Contributor

@hai-kreate hai-kreate commented Jun 2, 2023

This quick draft fills another missing piece from full CIP-30 support. Open questions:

  • How should we organize the types?
  • How should we implement this for the wallet emulator?
  • Should we write a utility function to verify signed data as well?

Sorry again for the spaces... I'll remove them if it's too distracting for the open discussion.

@hai-kreate hai-kreate marked this pull request as draft June 2, 2023 10:02
@christianschmitz
Copy link
Contributor

PR #116 implements this partially, but signData still missing from SimpleWallet (aka. WalletEmulator) hasn't implemented this yet though.

@roschler
Copy link

roschler commented Dec 3, 2023

"PR #116 implements this partially, but signData still missing from SimpleWallet (aka. WalletEmulator) hasn't implemented this yet though."

@christianschmitz Is this something you need me to do to complete that PR? SimpleWallet is new to me so I don't know if it's part of a full implementation for signData.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants