Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limitation warning messages not being displayed correctly #447

Closed
jurgyy opened this issue Feb 11, 2023 · 1 comment
Closed

Limitation warning messages not being displayed correctly #447

jurgyy opened this issue Feb 11, 2023 · 1 comment
Assignees
Labels

Comments

@jurgyy
Copy link

jurgyy commented Feb 11, 2023

Crafting Speed in the mod's interface caps at 12 and using the mod Space Exploration, you can easily reach a crafting speed higher than that. For instance a Space Manufactory has a base speed of 10 and has six module slots. So two T1 speed modules (20% each) already breaks the calculator. Strangely enough the interface also reports the warning "Limitation speed because the value cannot be reduced more than 80%" leaving me to believe some overflow is happening under the hood.

I have validated it in practice and more speed modules does actually increase the speed at which items are crafted. The side bar when hovering over the Space Manufactory also correctly states a crafting speed higher than 12.

Reproduction:

  1. Install Space Exploration
  2. Select any recipe that can be crafted in a Space Manufactory, which is most.
  3. Add two Speed Modules of any tier.

Anyway, here are some screenshots:
Helmod:
image

In game:
image

@KiwiHawk KiwiHawk added this to the Helmod 0.12.15 milestone Feb 12, 2023
@KiwiHawk
Copy link
Collaborator

There is a bug here with Helmod but it is comparatively minor. The Limitation warning that it's giving you isn't correct. The numbers that it shows are correct though. There is a base game limitation where each recipe can complete a maximum of once per tick (aka 60 times per second). You will see a higher speed value in Helmod for recipes with a longer craft time.

The speed shown by the side bar in game doesn't take this cap into account. However if you look at the production graph, you will see that Helmod's numbers are correct.

Here's an example with the limitation message fixed:
image

image

image

@KiwiHawk KiwiHawk changed the title Crafting Speed caps at 12 Limitation warning messages not being displayed correctly Feb 12, 2023
KiwiHawk added a commit that referenced this issue Feb 12, 2023
@KiwiHawk KiwiHawk self-assigned this Feb 12, 2023
@KiwiHawk KiwiHawk added the bug label Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants