Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate style-options in tests #108

Merged
merged 1 commit into from
Jan 10, 2021
Merged

Reinstate style-options in tests #108

merged 1 commit into from
Jan 10, 2021

Conversation

Helcaraxan
Copy link
Owner

Pull Request

Checklist

  • Changes are lint-free. You can check this by running ./ci/lint.sh or by opening a draft PR to trigger the continuous integration pipeline.
  • All tests pass. You can check this by running ./ci/test.sh or by opening a draft PR to trigger the continuous integration pipeline.
  • If relevant, tests have been updated or added to ensure your changes will not be reverted or broken by future PRs.
  • If relevant, the project's documentation has been updated or extended.
  • If relevant, information has been added to the release-notes document.
  • You have filled in the two sections below and deleted their corresponding placeholders texts.

Summary

Since the removal of the dot wrapping in #80 we were no longer appropriately passing the required style options to the test resulting in drift in one of the test-cases.

Tests

Fixed & updated test-case.

@Helcaraxan Helcaraxan self-assigned this Jan 10, 2021
@Helcaraxan Helcaraxan merged commit 4e172ee into master Jan 10, 2021
@Helcaraxan Helcaraxan deleted the fix-core-tests branch January 10, 2021 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant