[Balance] Fix Eclipse entry sequence with Lunar's Calling talent #4262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Potentially fixes Hekili#4248 This PR addresses an issue with Balance Druid Eclipse entry sequences when using the Lunar's Calling talent. Previously, the addon would incorrectly suggest ability switches during Eclipse entry casts, particularly when trying to enter Lunar Eclipse. Changes: 1. Updated DruidBalance.simc to prevent ability switching during Eclipse entry: - Added Eclipse counter and previous GCD checks to Wrath/Starfire conditions - Ensures proper spell sequencing when entering Eclipse phases - Prevents suggestions from changing mid-cast during Eclipse entry sequences 2. Enhanced Eclipse state management in DruidBalance.lua: - Added logic to prevent state changes during critical Eclipse entry casts - Improved state transition handling during Eclipse sequences - Better handling of the Lunar's Calling talent interaction The changes ensure that: - Double Wrath casts work properly when entering Lunar Eclipse with Lunar's Calling - The rotation doesn't flip-flop between suggestions during Eclipse entry - Eclipse entry sequences remain smooth and consistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially fixes #4248
This PR addresses an issue with Balance Druid Eclipse entry sequences when using the Lunar's Calling talent. Previously, the addon may incorrectly suggest ability switches during Eclipse entry casts, particularly when trying to enter Lunar Eclipse.
Changes:
The changes ensure that: