Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frost Mage] Add Fingers of Frost timing check to Flurry conditions #4261

Open
wants to merge 2 commits into
base: thewarwithin
Choose a base branch
from

Conversation

joshjau
Copy link
Contributor

@joshjau joshjau commented Dec 23, 2024

Potentially addresses issue #4260 where Flurry recommendations could occur at suboptimal times during high-haste situations (Bloodlust + Icy Veins).

Changes:

  • Added condition (!buff.fingers_of_frost.react|buff.fingers_of_frost.remains>1) to Flurry usage in single-target, cleave, and AoE action lists
  • This ensures Flurry isn't recommended if Fingers of Frost is about to proc within 1 second
  • Makes recommendations more practical for human players while maintaining proper Flurry usage after Frostbolt/Glacial Spike casts

The change helps prevent rapid recommendation switches during high-haste periods while still allowing optimal Flurry usage patterns. This makes the addon's suggestions more consistent and easier to follow during intense combat situations.

Potentially addresses issue Hekili#4260 where Flurry recommendations could occur at suboptimal times during high-haste situations (Bloodlust + Icy Veins).

Changes:
- Added condition `(!buff.fingers_of_frost.react|buff.fingers_of_frost.remains>1)` to Flurry usage in single-target, cleave, and AoE action lists
- This ensures Flurry isn't recommended if Fingers of Frost is about to proc within 1 second
- Makes recommendations more practical for human players while maintaining proper Flurry usage after Frostbolt/Glacial Spike casts

The change helps prevent rapid recommendation switches during high-haste periods while still allowing optimal Flurry usage patterns. This makes the addon's suggestions more consistent and easier to follow during intense combat situations.
@yokaii4
Copy link

yokaii4 commented Dec 23, 2024

Thanks for checking out my ticket! By the way there's a similar issue with Ray of Frost where the addon suggest it to you but then it quickly disappears because it gives prio to freezing winds. You can check it out simply by executing the rotation. I believe a solution can be forcing the addon to recommend Ray of frost after the first ice lance in freezing winds because the second proc always comes in around 2s which is the perfect time to not waste a finger of frost proc and get value fast from the ray. Instead now the addon will wait a dozen of gcd before actually recommending ray. I will open a ticket later and tag you so you can check it out

P.S.: noticed that with last update Ray of frost is more consistent. What happens now is that it gets recommended, then the addon quickly cancels it and then gets recommended a few globals later. I think that some general adjusting to the whole BL + icy veins and/or freezing winds would make the addon easier to follow. Probably with PI too

@yokaii4
Copy link

yokaii4 commented Dec 23, 2024

Have another note too: when we play spellsinger we aim to cast as many orbs as possible and holding a orb charge for icy veins is generally not worth it (unless we talk about a couple of seconds). For this reason I suggest moving frozen orb out of the CD toggle and have it use on cd (if you want to min max you can set it to hold for IV only if like there are 5s remaining)

Essentially SS tries to play the orbs casino as much as possible to get as many orbs casts we can therefore the orbs casts>syncing it with icy veins for overall dps

@syrifgit
Copy link
Collaborator

Just remember that manual edits to APL must be maintained manually and double checked every update.

@yokaii4
Copy link

yokaii4 commented Dec 23, 2024

Just remember that manual edits to APL must be maintained manually and double checked every update.

so this is not something that will be implemented?

@syrifgit
Copy link
Collaborator

I didn't say that, I was just advising the PR creator that it can be a bit of a pain to maintain manual deviations from SIMC, speaking from experience.

@yokaii4
Copy link

yokaii4 commented Dec 23, 2024

I didn't say that, I was just advising the PR creator that it can be a bit of a pain to maintain manual deviations from SIMC, speaking from experience.

oh alright. Was asking bc I also left some comments to add to the OP comment that can optimize a bit how spellsinger frost works

@yokaii4
Copy link

yokaii4 commented Dec 23, 2024

Have another suggestion too: would it be possible to add a condition to cone of cold to detect the targets range? Sometimes i have noticed that coc gets recommended without considering the targets positions since for ranged the target count is determined if they got hit or not. Would this be possible or too specific?

@syrifgit
Copy link
Collaborator

Have another suggestion too: would it be possible to add a condition to cone of cold to detect the targets range? Sometimes i have noticed that coc gets recommended without considering the targets positions since for ranged the target count is determined if they got hit or not. Would this be possible or too specific?

You think you do but you don't. You should learn your spec and know that cone of cold requires you to be close.

Having it not show up because you aren't in range would brick your rotation.

As always whenever this topic comes up, the highest DPS choice is to get back in range.

@yokaii4
Copy link

yokaii4 commented Dec 23, 2024

Have another suggestion too: would it be possible to add a condition to cone of cold to detect the targets range? Sometimes i have noticed that coc gets recommended without considering the targets positions since for ranged the target count is determined if they got hit or not. Would this be possible or too specific?

You think you do but you don't. You should learn your spec and know that cone of cold requires you to be close.

Having it not show up because you aren't in range would brick your rotation.

As always whenever this topic comes up, the highest DPS choice is to get back in range.

You are right did not think about it. Was mainly throwing the suggestion there to check if it was viable, but as I said lots of time I'm the first advocate saying that Hekili should be checked from time to time at best and not be your rotation bible. Ultimately I'm (weirdly) having fun spotting issues/asking for possible solutions while playing lol

…ted in Hekili#4260.

Changes:
- Modified Flurry timing conditions to be more conservative during high-haste periods
- Increased FoF timing check from 1s to 1.5s for better human playability
- Added specific handling for Freezing Winds + Icy Veins interaction with:
  `(!talent.freezing_winds|!buff.icy_veins.up|buff.fingers_of_frost.remains>2)`

This should prevent the addon from recommending Flurry at suboptimal times during Bloodlust + Icy Veins windows, particularly with the Freezing Winds talent, while still maintaining proper Flurry usage after Frostbolt/Glacial Spike casts.
@joshjau
Copy link
Contributor Author

joshjau commented Dec 24, 2024

@yokaii4 Could you test these changes and verify if they resolve the rapid recommendation switches you were experiencing? I made another adjustment. As for Frozen Orb, if I make this change, it will probably be rejected by Hekili, but it is easily do-able and deviates from the APL.

@yokaii4
Copy link

yokaii4 commented Dec 24, 2024

  • (!buff.fingers_of_frost.react|buff.fingers_of_frost.remains>1)

I tried the flurry conditions but unfortunately it doesn't fix it: the reason why is that I think we need a "forced" condition that flurry must be queuecasted to either a glacial spike or frostbolt. What happens with this new condition is that the issue remains and instead it could ignore the queuecast recommendation because it gives prio to the "buff.fingers_of_frost.remains>1)"

I am not sure if at this point it is fixable since in BL it moves too quickly and there are a lot of variables (orb procs for instance)

Another point I would try to work around, though, is the pet Freeze usage: bosses are immune to freeze, so we shatter only with Winter's chill. Maybe it could be possible to optimize the freeze recommendation by disabling it on boss fights with ST condition? I would only allow it for AOE boss fights conditions since those are usually adds sections.
Worth to note that freeze is off gcd so even casting it on boss doesn't really change much at the end of the day. It's more of a matter of visual clarity in the recommendations

@yokaii4
Copy link

yokaii4 commented Dec 26, 2024

Hey @joshjau hope you had a great Christmas :)

I have another adjustment, this time regarding Blizzard:
If we are playing spellsinger and have no Ice Caller and Freezing Rain then you only wanna cast Blizzard at 5+ targets
As Frostfire if you don't have neither of the talents above Blizzard shouldn't be casted since it's a dps loss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants