Skip to content

Commit

Permalink
[Dashboard] Rename Dashboard to Dashboards (elastic#170992)
Browse files Browse the repository at this point in the history
Closes elastic#163152

## Summary

This PR renames the "Dashboard" app to "Dashboards" in both the side
navigation and the breadcrumbs, like so:

| Before | After |
|--------|--------|
| <img width="344" alt="Screenshot 2023-11-10 at 10 53 37 AM"
src="https://github.com/elastic/kibana/assets/8698078/a8b821f6-925d-4589-a763-ca70950a5b8b">
| <img width="344" alt="Screenshot 2023-11-10 at 10 54 12 AM"
src="https://github.com/elastic/kibana/assets/8698078/0812627e-8cf4-48df-b9fc-8ce435b09dd0">
|
| <img width="508" alt="Screenshot 2023-11-10 at 10 57 51 AM"
src="https://github.com/elastic/kibana/assets/8698078/970636ab-c48a-4204-bb59-c0a6f50fb0f4">
| <img width="508" alt="Screenshot 2023-11-10 at 10 57 14 AM"
src="https://github.com/elastic/kibana/assets/8698078/48ceb444-38ec-4c6c-8885-8cc504eee2c5">
|

This is more consistent with Visualizations, Maps, etc., the dashboard
listing page, and dashboard URLs.


### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
  • Loading branch information
Heenawter authored Nov 10, 2023
1 parent 682600f commit 4b55f11
Show file tree
Hide file tree
Showing 8 changed files with 7 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ export const shareModalStrings = {
*/
export const getDashboardBreadcrumb = () =>
i18n.translate('dashboard.dashboardAppBreadcrumbsTitle', {
defaultMessage: 'Dashboard',
defaultMessage: 'Dashboards',
});

export const topNavStrings = {
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/dashboard/public/plugin.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ export class DashboardPlugin

const app: App = {
id: DASHBOARD_APP_ID,
title: 'Dashboard',
title: 'Dashboards',
order: 2500,
euiIconType: 'logoKibana',
defaultPath: `#${LANDING_PAGE_PATH}`,
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/fr-FR.json
Original file line number Diff line number Diff line change
Expand Up @@ -1204,7 +1204,6 @@
"dashboard.createConfirmModal.continueButtonLabel": "Poursuivre les modifications",
"dashboard.createConfirmModal.unsavedChangesSubtitle": "Poursuivez les modifications ou utilisez un tableau de bord vierge.",
"dashboard.createConfirmModal.unsavedChangesTitle": "Nouveau tableau de bord déjà en cours",
"dashboard.dashboardAppBreadcrumbsTitle": "Tableau de bord",
"dashboard.dashboardPageTitle": "Tableaux de bord",
"dashboard.dashboardWasSavedSuccessMessage": "Le tableau de bord \"{dashTitle}\" a été enregistré.",
"dashboard.deleteError.toastDescription": "Erreur rencontrée lors de la suppression du tableau de bord",
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/ja-JP.json
Original file line number Diff line number Diff line change
Expand Up @@ -1218,7 +1218,6 @@
"dashboard.createConfirmModal.continueButtonLabel": "編集を続行",
"dashboard.createConfirmModal.unsavedChangesSubtitle": "編集を続行するか、空のダッシュボードで始めてください。",
"dashboard.createConfirmModal.unsavedChangesTitle": "新しいダッシュボードはすでに実行中です",
"dashboard.dashboardAppBreadcrumbsTitle": "ダッシュボード",
"dashboard.dashboardPageTitle": "ダッシュボード",
"dashboard.dashboardWasSavedSuccessMessage": "ダッシュボード「{dashTitle}」が保存されました。",
"dashboard.deleteError.toastDescription": "ダッシュボードの削除中にエラーが発生しました",
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/zh-CN.json
Original file line number Diff line number Diff line change
Expand Up @@ -1218,7 +1218,6 @@
"dashboard.createConfirmModal.continueButtonLabel": "继续编辑",
"dashboard.createConfirmModal.unsavedChangesSubtitle": "继续编辑或使用空白仪表板从头开始。",
"dashboard.createConfirmModal.unsavedChangesTitle": "新仪表板已在创建中",
"dashboard.dashboardAppBreadcrumbsTitle": "仪表板",
"dashboard.dashboardPageTitle": "仪表板",
"dashboard.dashboardWasSavedSuccessMessage": "仪表板“{dashTitle}”已保存",
"dashboard.deleteError.toastDescription": "删除仪表板时发生错误",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {

it('only shows the dashboard navlink', async () => {
const navLinks = await appsMenu.readLinks();
expect(navLinks.map((link) => link.text)).to.eql(['Dashboard', 'Stack Management']);
expect(navLinks.map((link) => link.text)).to.eql(['Dashboards', 'Stack Management']);
});

it(`landing page shows "Create new Dashboard" button`, async () => {
Expand Down Expand Up @@ -286,7 +286,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {

it('shows dashboard navlink', async () => {
const navLinks = (await appsMenu.readLinks()).map((link) => link.text);
expect(navLinks).to.eql(['Dashboard']);
expect(navLinks).to.eql(['Dashboards']);
});

it(`landing page doesn't show "Create new Dashboard" button`, async () => {
Expand Down Expand Up @@ -398,7 +398,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {

it('shows dashboard navlink', async () => {
const navLinks = (await appsMenu.readLinks()).map((link) => link.text);
expect(navLinks).to.eql(['Dashboard']);
expect(navLinks).to.eql(['Dashboards']);
});

it(`landing page doesn't show "Create new Dashboard" button`, async () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
basePath: '/s/custom_space',
});
const navLinks = (await appsMenu.readLinks()).map((link) => link.text);
expect(navLinks).to.contain('Dashboard');
expect(navLinks).to.contain('Dashboards');
});

it(`landing page shows "Create new Dashboard" button`, async () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {

it('should not show the Stack Management nav link', async () => {
const links = await appsMenu.readLinks();
expect(links.map((link) => link.text)).to.eql(['Dashboard']);
expect(links.map((link) => link.text)).to.eql(['Dashboards']);
});

it('should render the "application not found" view when navigating to management directly', async () => {
Expand Down

0 comments on commit 4b55f11

Please sign in to comment.