Fx background field color and refactor environment variables #1572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -311,37 +311,27 @@ struct hFloatingTextField_Previews: PreviewProvider { | |||
| } | |||
| } | |||
|
|
|||
| private struct EnvironmentHWithoutDisabledColor: EnvironmentKey { | |||
| static let defaultValue = false | |||
| public enum BackgroundColorType { | |||
There was a problem hiding this comment.
Really good idea to handle them like this, but naming maybe needs to be updated like
BackgroundOption or something similar
There was a problem hiding this comment.
Yeah that sounds good! Updated it 👍
added 2 commits
October 17, 2024 16:34
Checked it and I think it looks good :) |
sladan-hedvig
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[APP-XXX]
Checklist