Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out cancellation exceptions for RUM errors #2348

Conversation

StylianosGakis
Copy link
Member

@StylianosGakis StylianosGakis commented Dec 11, 2024

Context:
DataDog/dd-sdk-android#2426 (comment)

Tested by adding an interceptor which cancels all requests

    val okHttpBuilder = get<OkHttpClient.Builder>().addInterceptor(get<AuthTokenRefreshingInterceptor>())
      .addInterceptor {
        it.call().cancel()
        it.proceed(it.request())
      }

and seeing what that error looks like for the event mapper.
Then we simply drop the error event as suggested in the linked discussion

@StylianosGakis StylianosGakis requested a review from a team as a code owner December 11, 2024 13:52
@StylianosGakis StylianosGakis merged commit 9be2bb2 into develop Dec 12, 2024
4 checks passed
@StylianosGakis StylianosGakis deleted the improvement/do-not-report-cancelled-requests-as-RUM-errors branch December 12, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants