[test] Offpiste/shared element cards #2147
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
migration/compose-typed-simpler-typemaps
to
develop
July 31, 2024 08:54
# Conflicts: # app/feature/feature-terminate-insurance/src/main/kotlin/com/hedvig/android/feature/terminateinsurance/step/survey/TerminationSurveyDestination.kt # gradle/libs.versions.toml
Nullable primitive types are supported out of the box. Still waiting for better support for enums with the tracking bug being: https://issuetracker.google.com/issues/358137294
This makes it match properly even while the content is still being loaded
We want the loading case to look exactly the same on the first frame so that the shared element transition does not have a flickering effect
Fallback to just rendering the old black color fallback otherwise Use the SSH to grab the route in the VM without having to do something on the DI setup
Fallback to just rendering the old black color fallback otherwise Use the SSH to grab the route in the VM without having to do something on the DI setup
This gives it the right image to show in the first frame when navigating to that screen.
Just merge them to the public module instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test, do not merge