Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEGA NN] NodeNameList chunk spec #68

Merged
merged 2 commits into from
Mar 16, 2024

Conversation

TheExentist151
Copy link
Contributor

No description provided.

Copy link
Member

@Radfordhound Radfordhound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, thanks a lot for helping out!

There's two very minor changes I'd like to make to make it a little easier for devs reading this to tell what the sizes of the fields are. Then, LGTM

@TheExentist151
Copy link
Contributor Author

Thanks for the review! I changed the type of iNode in NNS_NODENAME struct to uint32_t, because the nNode variable is uint32_t too.

I can't really check the base type of the NNE_NODENAME_SORTTYPE struct, but I think this is just a uint32_t.

@Radfordhound
Copy link
Member

Thanks, I appreciate it! The base type thing is fine; if we figure it out someday we can just add it in later.

@Radfordhound Radfordhound merged commit 06f3988 into HedgeDocs:main Mar 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants