fix: correctly parse cookies (#24)

packages/authjs-nuxt/package.json

@@ -49,10 +49,12 @@
     "defu": "^6.1.2",
     "immer": "^10.0.2",
     "jose": "^4.14.4",
+    "set-cookie-parser": "^2.6.0",
     "unctx": "^2.3.1"
   },
   "devDependencies": {
     "@nuxt/module-builder": "^0.4.0",
+    "@types/set-cookie-parser": "^2.4.2",
     "h3": "^1.7.1",
     "vue": "^3.3.4"
   },

packages/authjs-nuxt/src/runtime/utils.ts

@@ -1,5 +1,6 @@
 import type { AuthConfig } from "@auth/core"
 import { parse } from "cookie-es"
+import setCookieParser from "set-cookie-parser"
 import type { H3Event, RequestHeaders } from "h3"
 import { getMethod, getRequestHeaders, getRequestURL, readRawBody, sendRedirect } from "h3"
 import type { RuntimeConfig } from "@nuxt/schema"
@@ -42,7 +43,7 @@ export function makeCookiesFromCookieString(cookieString: string | null) {
 
 export function makeNativeHeadersFromCookieObject(headers: Record<string, string>) {
   const nativeHeaders = new Headers(Object.entries(headers)
-    .map(([key, value]) => ["Set-Cookie", `${key}=${value}`]) as HeadersInit)
+    .map(([key, value]) => ["set-cookie", `${key}=${value}`]) as HeadersInit)
   return nativeHeaders
 }
 
@@ -82,13 +83,22 @@ export async function respondWithResponse(event: H3Event, response: Response) {
   for (const [key, value] of response.headers)
     event.node.res.setHeader(key, value)
 
+  const cookieHeader = response.headers.get("set-cookie")
+  if (cookieHeader) {
+    const cookieString = setCookieParser.splitCookiesString(cookieHeader)
+    event.node.res.setHeader("set-cookie", cookieString)
+  }
+
   if (response.status === 302 && response.headers.get("Location")) {
     event.node.res.statusCode = 302
     return sendRedirect(event, response.headers.get("Location") as string)
   }
+
   if (response.body) {
-    for await (const chunk of response.body as unknown as AsyncIterable<Uint8Array>)
-      event.node.res.write(chunk)
+    const contentType = response.headers.get("Content-Type") || ""
+    if (contentType.includes("text") || contentType.includes("json"))
+      for await (const chunk of response.body as unknown as AsyncIterable<Uint8Array>) event.node.res.write(new TextDecoder().decode(chunk))
+    else for await (const chunk of response.body as unknown as AsyncIterable<Uint8Array>) event.node.res.write(chunk)
   }
   return event.node.res.end()
 }

packages/authjs-nuxt/test/auth.test.ts

@@ -9,7 +9,7 @@ describe("all", () => {
   it("can transform cookie object into headers", () => {
     const cookies = { hello: "world", hi: "there" }
     const headers = makeNativeHeadersFromCookieObject(cookies)
-    expect(headers.get("Set-Cookie")).toBe("hello=world, hi=there")
+    expect(headers.get("set-cookie")).toBe("hello=world, hi=there")
     expect(headers instanceof Headers).toBe(true)
   })