Revert consul-template to latest upstream #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream consul-template now accepts a stdlib logger for its child implementation, which allows us to move off the older fork of consul-template we've been using. Rather than implement a shim between logrus and the stdlib logger, this PR also updates remco to use hclog and use its provided shim instead. This is functionally equivalent to what we were using logrus for, although likely not byte-for-byte compatible with the older format of the logs. Lastly, as part of this migration away from logrus, a couple of exposed methods have been removed from the log module (SetLevel, SetOutput) which were unused outside of tests (for said methods).
|
seems to have one failing test - let me dig into that |
LGTM. I don't see any failing test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream consul-template now accepts a stdlib logger for its child
implementation, which allows us to move off the older fork of
consul-template we've been using. Rather than implement a shim between
logrus and the stdlib logger, this PR also updates remco to use hclog
and use its provided shim instead.
This is functionally equivalent to what we were using logrus for,
although likely not byte-for-byte compatible with the older format of
the logs.
Lastly, as part of this migration away from logrus, a couple of
exposed methods have been removed from the log module (SetLevel,
SetOutput) which were unused outside of tests (for said methods).
Two additional changes are included here (separate commits):