Strictly enforce the node version required #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is helpful to avoid versions that will fail and with loud npm install output, warnings can go unseen. With this change because of the engine requirements specified upstream by the minecraft-protocol package if someone attempts to npm install with an unsupported version of node the process will abort with an error.
|
Wait, but this also blocks newer Node versions that seem like they should work fine? |
|
@Heath123 it works similar to how versions are set in the package.json. You can give a range I just checked out the main branch and it looks like the version of That is what is currently stopping node v20 for being valid for example. The latest version of that package does not have that engine requirement. I'm not sure what all upgrading packages would entail but that should solve the issue of not being able to run the latest node versions. |
andrewhood125
added a commit
to andrewhood125/pakkit
that referenced
this pull request
Jan 3, 2024
Background information [here]. [here](Heath123#101)
andrewhood125
added a commit
to andrewhood125/pakkit
that referenced
this pull request
Jan 3, 2024
Background information [here]. [here]: Heath123#101
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is helpful to avoid node versions that will fail. With loud npm install output, warnings can go unseen. With this change because of the engine requirements specified upstream by the minecraft-protocol package if someone attempts to npm install with an unsupported version of node the process will abort with an error.