add: contribution doc and fix use_latest template tag #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahharsh176
force-pushed
the
docs/contributing
branch
from
d04b8dc to
094ef37
Compare
shahharsh176
force-pushed
the
docs/contributing
branch
from
f95b77d to
9f9ab8f
Compare
shahharsh176
changed the title
kc-diabeat
requested changes
Aug 1, 2024
There was a problem hiding this comment.
Can we also add the docstring for this function, including the rationale and the usage pattern? @deepakdinesh1123 @shahharsh176
There was a problem hiding this comment.
Also not sure why we are including this change in this PR..We will be having another PR where the template file for app panel is being updated to use this template tag. Shouldn't we have this change in that PR?
There was a problem hiding this comment.
It's already merged, that's why I included the fix in this PR
There was a problem hiding this comment.
@kc-diabeat added the docstring
kc-diabeat
approved these changes
Aug 1, 2024
deepakdinesh1123
added a commit
that referenced
this pull request
Aug 2, 2024
* add: contribution doc and fix use_latest template tag fix * chore: add doc_string for use_latest filter --------- Co-authored-by: Harsh Shah <[email protected]>
kc-diabeat
added a commit
that referenced
this pull request
Aug 2, 2024
* support for telemetry and logging * fixed incorrect middleware name * added docstrings and setup otel for loguru * sending logs to otel * init * django settings module variable set in post_fork * trace export error fixed * refactor: base settings * add: OTEL_RESOURCE_ATTRIBUTES env var * zango release workflow added (#301) * zango release workflow added * branch updated, workflow name corrected * version and changelog checks added * image link updated * feat: added frontend build generation workflow (#316) * autoincrement filter added * filter renamed * filter renamed * feat: added frontend build generation workflow * fix: api token added, LICENSE file removed --------- Co-authored-by: deepakdinesh1123 <[email protected]> Co-authored-by: Harsh Shah <[email protected]> * Deploy frontend build * add: contribution doc and fix use_latest template tag (#293) * add: contribution doc and fix use_latest template tag fix * chore: add doc_string for use_latest filter --------- Co-authored-by: Harsh Shah <[email protected]> * added version for dependencies (#320) * added version for dependencies * Update base.txt django-rest-knox version fixed * auditlogs now gets default timezone of host if timezone is not specified (#322) * auditlogs now gets default timezone of host if timezone is not specified * tzlocal removed * remove unused import --------- Co-authored-by: Harsh Shah <[email protected]> * support for telemetry and logging * otel resource attributes variable removed * python-dotenv removed * fix: shift handler and logger inside setup_setting for avoiding error on existing project --------- Co-authored-by: kc-diabeat <[email protected]> Co-authored-by: deepakdinesh1123 <[email protected]> Co-authored-by: Harsh Shah <[email protected]> Co-authored-by: deepakdinesh1123 <[email protected]> Co-authored-by: Ravi Patel <[email protected]> Co-authored-by: Harsh Shah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.