internal_use_only decorator added and login url changed #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepakdinesh1123
changed the title
kc-diabeat
reviewed
May 16, 2024
| PlatformUserLoginView.as_view(), | ||
| name="login", | ||
| r"^auth/", | ||
| include("zango.apps.shared.platformauth.urls"), | ||
| ), | ||
| re_path(r"^admin/", admin.site.urls), |
There was a problem hiding this comment.
We can remove admin as we are not using it..
|
|
||
| urlpatterns = [ | ||
| re_path( | ||
| r"^admin/login/$", | ||
| PlatformUserLoginView.as_view(), | ||
| name="login", |
There was a problem hiding this comment.
We should enforce internal_ip in a blanket way for all platform endpoints.
deepakdinesh1123
force-pushed
the
feat/internal_use_only_decorator
branch
from
182b43d to
006c8ed
Compare
kc-diabeat
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #218