-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Practicals 1-4 #24
base: main
Are you sure you want to change the base?
Practicals 1-4 #24
Conversation
clead6
commented
Nov 21, 2024
- Finished writing up practicals 1-4
- Updated the setup instructions and added a link to download dataset and jupyter notebooks.
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/HealthBioscienceIDEAS/Medical-Image-Registration-Short-Course/compare/md-outputs..md-outputs-PR-24 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2025-01-06 14:33:39 +0000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @clead6 apologies for delay in reviewing, but this is great, very much appreciate all the changes and work you have added to these practicals and the notebooks. All of the notebooks ran for me using the new environment YAML file you provided. Most of my suggestions are minor formatting things.
For all practicals, I think it would be good to put a
::::::::::::::::::::keypoints
::::::::::::::::::::
section at the end with the 2-3 main takeaways from each practical.
Over to you @jamie-mcclelland - apologies again it took me so long.
Co-authored-by: davecash75 <[email protected]>
Co-authored-by: davecash75 <[email protected]>
Co-authored-by: davecash75 <[email protected]>
Co-authored-by: davecash75 <[email protected]>
Co-authored-by: davecash75 <[email protected]>
Co-authored-by: davecash75 <[email protected]>
Co-authored-by: davecash75 <[email protected]>
Co-authored-by: davecash75 <[email protected]>
Co-authored-by: davecash75 <[email protected]>
Co-authored-by: davecash75 <[email protected]>
Co-authored-by: davecash75 <[email protected]>
Co-authored-by: davecash75 <[email protected]>
Co-authored-by: davecash75 <[email protected]>
Co-authored-by: davecash75 <[email protected]>
Co-authored-by: davecash75 <[email protected]>
Co-authored-by: davecash75 <[email protected]>
added instructions to install itk-snap and also specify version used for practical (note - still need to add specific version used) minor edit to practical 1 instructions
modified sections 2.1 and 2.2 also minor edits to make formatting consistent
updated section 2.3 (prev 2.4) also modified figures to display as desired
updated figures for opening image
some updates to 2.4
Related to an above comment about the setup instructions. Do we want to explain:
|
Co-authored-by: davecash75 <[email protected]>
Added this in commit 4aa1227 |
finished section on loading multiple images (2.4) made other minor changes to previous sections
updated itk-snap install instructions
updated section on image layer inspector (now numbered 2.4)
modified section 3 - converting dicom image to nifti - now use itk-snap instead of simpleitk
changes to section numbers and some formatting