Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1 switch to carpentriessandpaper #22

Merged
merged 11 commits into from
Sep 4, 2024
Merged

Conversation

davecash75
Copy link
Contributor

Description

Fixes #1: Now that sandpaper change has been implemented, I have adjusted not only the config.yaml file as @milanmlft suggested, but also the setting up instructions, which included a lot of how the repository
was originally created. Since that has already been done, new users won't have to do that anymore.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Suggested Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have commented my code, particularly in hard-to-understand areas
  • I have read the CONTRIBUTING docs
  • My code passes, following the style guidelines pre-commit run -a
  • My code is properly tested with pytest -sv tests
  • This pull request is ready to be reviewed
  • Make sure your branch is up-to-date with main branch. See below a general example if rebase is need.
git checkout main
git pull origin main
git checkout FEATURE_BRANCH 
git rebase main
#git status
#edit conflicting files with your editor
#git rebase --continue
#git add .
git push --force origin FEATURE_BRANCH

@davecash75 davecash75 linked an issue Aug 29, 2024 that may be closed by this pull request
2 tasks
Copy link

github-actions bot commented Aug 29, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/HealthBioscienceIDEAS/Medical-Image-Registration-Short-Course/compare/md-outputs..md-outputs-PR-22

The following changes were observed in the rendered markdown documents:

 md5sum.txt | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-09-04 13:25:10 +0000

@davecash75 davecash75 requested a review from milanmlft August 29, 2024 13:00
github-actions bot pushed a commit that referenced this pull request Aug 29, 2024
Copy link
Contributor

@milanmlft milanmlft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a small suggestion to simplify the docs

_setting_up/README.md Outdated Show resolved Hide resolved
_setting_up/README.md Outdated Show resolved Hide resolved
_setting_up/README.md Outdated Show resolved Hide resolved
davecash75 and others added 2 commits August 30, 2024 12:09
Co-authored-by: Milan Malfait <[email protected]>
Co-authored-by: Milan Malfait <[email protected]>
github-actions bot pushed a commit that referenced this pull request Aug 30, 2024
To address Milan's suggestion to simplify
github-actions bot pushed a commit that referenced this pull request Aug 30, 2024
Moving varnish after sandpaper
github-actions bot pushed a commit that referenced this pull request Sep 2, 2024
small indent
github-actions bot pushed a commit that referenced this pull request Sep 4, 2024
Two typos spotted by Jamie
github-actions bot pushed a commit that referenced this pull request Sep 4, 2024
RStudio for Windows needs an R project file.
@davecash75
Copy link
Contributor Author

Hi @milanmlft I think this is ready for a quick re-review. I tested it with @jamie-mcclelland on his Windows and some final changes were made.

github-actions bot pushed a commit that referenced this pull request Sep 4, 2024
Small changes around sandpaper:serve()
github-actions bot pushed a commit that referenced this pull request Sep 4, 2024
Copy link
Contributor

@milanmlft milanmlft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@milanmlft
Copy link
Contributor

Oh quick afterthought, it might be a good idea to clear the GHA caches, because I can see it still has the IDEAS-sandpaper fork installed. Clearing the cache should force re-installation.

@davecash75 davecash75 merged commit c956b45 into main Sep 4, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 24, 2024
Auto-generated via {sandpaper}
Source  : c956b45
Branch  : main
Author  : davecash75 <[email protected]>
Time    : 2024-09-04 13:55:52 +0000
Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper

1 switch to carpentriessandpaper
github-actions bot pushed a commit that referenced this pull request Sep 24, 2024
Auto-generated via {sandpaper}
Source  : 389ef32
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-09-24 00:16:53 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : c956b45
Branch  : main
Author  : davecash75 <[email protected]>
Time    : 2024-09-04 13:55:52 +0000
Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper

1 switch to carpentriessandpaper
github-actions bot pushed a commit that referenced this pull request Oct 1, 2024
Auto-generated via {sandpaper}
Source  : c956b45
Branch  : main
Author  : davecash75 <[email protected]>
Time    : 2024-09-04 13:55:52 +0000
Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper

1 switch to carpentriessandpaper
github-actions bot pushed a commit that referenced this pull request Oct 1, 2024
Auto-generated via {sandpaper}
Source  : cec59e1
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-10-01 00:17:52 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : c956b45
Branch  : main
Author  : davecash75 <[email protected]>
Time    : 2024-09-04 13:55:52 +0000
Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper

1 switch to carpentriessandpaper
github-actions bot pushed a commit that referenced this pull request Oct 8, 2024
Auto-generated via {sandpaper}
Source  : c956b45
Branch  : main
Author  : davecash75 <[email protected]>
Time    : 2024-09-04 13:55:52 +0000
Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper

1 switch to carpentriessandpaper
github-actions bot pushed a commit that referenced this pull request Oct 8, 2024
Auto-generated via {sandpaper}
Source  : 8258466
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-10-08 00:15:27 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : c956b45
Branch  : main
Author  : davecash75 <[email protected]>
Time    : 2024-09-04 13:55:52 +0000
Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper

1 switch to carpentriessandpaper
github-actions bot pushed a commit that referenced this pull request Oct 15, 2024
Auto-generated via `{sandpaper}`
Source  : c956b45
Branch  : main
Author  : davecash75 <[email protected]>
Time    : 2024-09-04 13:55:52 +0000
Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper

1 switch to carpentriessandpaper
github-actions bot pushed a commit that referenced this pull request Oct 15, 2024
Auto-generated via `{sandpaper}`
Source  : 8c7381b
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-10-15 00:16:02 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c956b45
Branch  : main
Author  : davecash75 <[email protected]>
Time    : 2024-09-04 13:55:52 +0000
Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper

1 switch to carpentriessandpaper
github-actions bot pushed a commit that referenced this pull request Oct 22, 2024
Auto-generated via `{sandpaper}`
Source  : c956b45
Branch  : main
Author  : davecash75 <[email protected]>
Time    : 2024-09-04 13:55:52 +0000
Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper

1 switch to carpentriessandpaper
github-actions bot pushed a commit that referenced this pull request Oct 22, 2024
Auto-generated via `{sandpaper}`
Source  : d00e3a1
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-10-22 00:16:05 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c956b45
Branch  : main
Author  : davecash75 <[email protected]>
Time    : 2024-09-04 13:55:52 +0000
Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper

1 switch to carpentriessandpaper
github-actions bot pushed a commit that referenced this pull request Oct 29, 2024
Auto-generated via `{sandpaper}`
Source  : c956b45
Branch  : main
Author  : davecash75 <[email protected]>
Time    : 2024-09-04 13:55:52 +0000
Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper

1 switch to carpentriessandpaper
github-actions bot pushed a commit that referenced this pull request Oct 29, 2024
Auto-generated via `{sandpaper}`
Source  : 1a6e954
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-10-29 00:16:23 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c956b45
Branch  : main
Author  : davecash75 <[email protected]>
Time    : 2024-09-04 13:55:52 +0000
Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper

1 switch to carpentriessandpaper
github-actions bot pushed a commit that referenced this pull request Nov 5, 2024
Auto-generated via `{sandpaper}`
Source  : c956b45
Branch  : main
Author  : davecash75 <[email protected]>
Time    : 2024-09-04 13:55:52 +0000
Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper

1 switch to carpentriessandpaper
github-actions bot pushed a commit that referenced this pull request Nov 5, 2024
Auto-generated via `{sandpaper}`
Source  : 43e30c1
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-11-05 00:15:53 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c956b45
Branch  : main
Author  : davecash75 <[email protected]>
Time    : 2024-09-04 13:55:52 +0000
Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper

1 switch to carpentriessandpaper
github-actions bot pushed a commit that referenced this pull request Nov 12, 2024
Auto-generated via `{sandpaper}`
Source  : c956b45
Branch  : main
Author  : davecash75 <[email protected]>
Time    : 2024-09-04 13:55:52 +0000
Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper

1 switch to carpentriessandpaper
github-actions bot pushed a commit that referenced this pull request Nov 12, 2024
Auto-generated via `{sandpaper}`
Source  : e044bf6
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-11-12 00:15:48 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c956b45
Branch  : main
Author  : davecash75 <[email protected]>
Time    : 2024-09-04 13:55:52 +0000
Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper

1 switch to carpentriessandpaper
github-actions bot pushed a commit that referenced this pull request Nov 19, 2024
Auto-generated via `{sandpaper}`
Source  : c956b45
Branch  : main
Author  : davecash75 <[email protected]>
Time    : 2024-09-04 13:55:52 +0000
Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper

1 switch to carpentriessandpaper
github-actions bot pushed a commit that referenced this pull request Nov 19, 2024
Auto-generated via `{sandpaper}`
Source  : ddde3f2
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-11-19 00:17:30 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c956b45
Branch  : main
Author  : davecash75 <[email protected]>
Time    : 2024-09-04 13:55:52 +0000
Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper

1 switch to carpentriessandpaper
github-actions bot pushed a commit that referenced this pull request Nov 26, 2024
Auto-generated via `{sandpaper}`
Source  : c956b45
Branch  : main
Author  : davecash75 <[email protected]>
Time    : 2024-09-04 13:55:52 +0000
Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper

1 switch to carpentriessandpaper
github-actions bot pushed a commit that referenced this pull request Nov 26, 2024
Auto-generated via `{sandpaper}`
Source  : 2b4f2d8
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-11-26 00:16:58 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c956b45
Branch  : main
Author  : davecash75 <[email protected]>
Time    : 2024-09-04 13:55:52 +0000
Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper

1 switch to carpentriessandpaper
github-actions bot pushed a commit that referenced this pull request Dec 3, 2024
Auto-generated via `{sandpaper}`
Source  : c956b45
Branch  : main
Author  : davecash75 <[email protected]>
Time    : 2024-09-04 13:55:52 +0000
Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper

1 switch to carpentriessandpaper
github-actions bot pushed a commit that referenced this pull request Dec 3, 2024
Auto-generated via `{sandpaper}`
Source  : 3acf55a
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-12-03 00:18:32 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c956b45
Branch  : main
Author  : davecash75 <[email protected]>
Time    : 2024-09-04 13:55:52 +0000
Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper

1 switch to carpentriessandpaper
github-actions bot pushed a commit that referenced this pull request Dec 10, 2024
Auto-generated via `{sandpaper}`
Source  : c956b45
Branch  : main
Author  : davecash75 <[email protected]>
Time    : 2024-09-04 13:55:52 +0000
Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper

1 switch to carpentriessandpaper
github-actions bot pushed a commit that referenced this pull request Dec 10, 2024
Auto-generated via `{sandpaper}`
Source  : db5a5d4
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-12-10 00:17:55 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c956b45
Branch  : main
Author  : davecash75 <[email protected]>
Time    : 2024-09-04 13:55:52 +0000
Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper

1 switch to carpentriessandpaper
github-actions bot pushed a commit that referenced this pull request Dec 17, 2024
Auto-generated via `{sandpaper}`
Source  : c956b45
Branch  : main
Author  : davecash75 <[email protected]>
Time    : 2024-09-04 13:55:52 +0000
Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper

1 switch to carpentriessandpaper
github-actions bot pushed a commit that referenced this pull request Dec 17, 2024
Auto-generated via `{sandpaper}`
Source  : 9ea4a9a
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-12-17 00:17:34 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c956b45
Branch  : main
Author  : davecash75 <[email protected]>
Time    : 2024-09-04 13:55:52 +0000
Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper

1 switch to carpentriessandpaper
github-actions bot pushed a commit that referenced this pull request Dec 24, 2024
Auto-generated via `{sandpaper}`
Source  : c956b45
Branch  : main
Author  : davecash75 <[email protected]>
Time    : 2024-09-04 13:55:52 +0000
Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper

1 switch to carpentriessandpaper
github-actions bot pushed a commit that referenced this pull request Dec 24, 2024
Auto-generated via `{sandpaper}`
Source  : 89d7b29
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-12-24 00:15:59 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c956b45
Branch  : main
Author  : davecash75 <[email protected]>
Time    : 2024-09-04 13:55:52 +0000
Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper

1 switch to carpentriessandpaper
github-actions bot pushed a commit that referenced this pull request Dec 31, 2024
Auto-generated via `{sandpaper}`
Source  : c956b45
Branch  : main
Author  : davecash75 <[email protected]>
Time    : 2024-09-04 13:55:52 +0000
Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper

1 switch to carpentriessandpaper
github-actions bot pushed a commit that referenced this pull request Dec 31, 2024
Auto-generated via `{sandpaper}`
Source  : 72f637a
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-12-31 00:15:58 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c956b45
Branch  : main
Author  : davecash75 <[email protected]>
Time    : 2024-09-04 13:55:52 +0000
Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper

1 switch to carpentriessandpaper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to carpentries/sandpaper
2 participants