-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1 switch to carpentriessandpaper #22
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/HealthBioscienceIDEAS/Medical-Image-Registration-Short-Course/compare/md-outputs..md-outputs-PR-22 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2024-09-04 13:25:10 +0000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a small suggestion to simplify the docs
Co-authored-by: Milan Malfait <[email protected]>
Co-authored-by: Milan Malfait <[email protected]>
To address Milan's suggestion to simplify
Moving varnish after sandpaper
small indent
Two typos spotted by Jamie
RStudio for Windows needs an R project file.
Hi @milanmlft I think this is ready for a quick re-review. I tested it with @jamie-mcclelland on his Windows and some final changes were made. |
Small changes around sandpaper:serve()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Oh quick afterthought, it might be a good idea to clear the GHA caches, because I can see it still has the IDEAS-sandpaper fork installed. Clearing the cache should force re-installation. |
Auto-generated via {sandpaper} Source : c956b45 Branch : main Author : davecash75 <[email protected]> Time : 2024-09-04 13:55:52 +0000 Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper 1 switch to carpentriessandpaper
Auto-generated via {sandpaper} Source : 389ef32 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-09-24 00:16:53 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : c956b45 Branch : main Author : davecash75 <[email protected]> Time : 2024-09-04 13:55:52 +0000 Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper 1 switch to carpentriessandpaper
Auto-generated via {sandpaper} Source : c956b45 Branch : main Author : davecash75 <[email protected]> Time : 2024-09-04 13:55:52 +0000 Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper 1 switch to carpentriessandpaper
Auto-generated via {sandpaper} Source : cec59e1 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-10-01 00:17:52 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : c956b45 Branch : main Author : davecash75 <[email protected]> Time : 2024-09-04 13:55:52 +0000 Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper 1 switch to carpentriessandpaper
Auto-generated via {sandpaper} Source : c956b45 Branch : main Author : davecash75 <[email protected]> Time : 2024-09-04 13:55:52 +0000 Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper 1 switch to carpentriessandpaper
Auto-generated via {sandpaper} Source : 8258466 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-10-08 00:15:27 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : c956b45 Branch : main Author : davecash75 <[email protected]> Time : 2024-09-04 13:55:52 +0000 Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper 1 switch to carpentriessandpaper
Auto-generated via `{sandpaper}` Source : c956b45 Branch : main Author : davecash75 <[email protected]> Time : 2024-09-04 13:55:52 +0000 Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper 1 switch to carpentriessandpaper
Auto-generated via `{sandpaper}` Source : 8c7381b Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-10-15 00:16:02 +0000 Message : markdown source builds Auto-generated via `{sandpaper}` Source : c956b45 Branch : main Author : davecash75 <[email protected]> Time : 2024-09-04 13:55:52 +0000 Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper 1 switch to carpentriessandpaper
Auto-generated via `{sandpaper}` Source : c956b45 Branch : main Author : davecash75 <[email protected]> Time : 2024-09-04 13:55:52 +0000 Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper 1 switch to carpentriessandpaper
Auto-generated via `{sandpaper}` Source : d00e3a1 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-10-22 00:16:05 +0000 Message : markdown source builds Auto-generated via `{sandpaper}` Source : c956b45 Branch : main Author : davecash75 <[email protected]> Time : 2024-09-04 13:55:52 +0000 Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper 1 switch to carpentriessandpaper
Auto-generated via `{sandpaper}` Source : c956b45 Branch : main Author : davecash75 <[email protected]> Time : 2024-09-04 13:55:52 +0000 Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper 1 switch to carpentriessandpaper
Auto-generated via `{sandpaper}` Source : 1a6e954 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-10-29 00:16:23 +0000 Message : markdown source builds Auto-generated via `{sandpaper}` Source : c956b45 Branch : main Author : davecash75 <[email protected]> Time : 2024-09-04 13:55:52 +0000 Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper 1 switch to carpentriessandpaper
Auto-generated via `{sandpaper}` Source : c956b45 Branch : main Author : davecash75 <[email protected]> Time : 2024-09-04 13:55:52 +0000 Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper 1 switch to carpentriessandpaper
Auto-generated via `{sandpaper}` Source : 43e30c1 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-11-05 00:15:53 +0000 Message : markdown source builds Auto-generated via `{sandpaper}` Source : c956b45 Branch : main Author : davecash75 <[email protected]> Time : 2024-09-04 13:55:52 +0000 Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper 1 switch to carpentriessandpaper
Auto-generated via `{sandpaper}` Source : c956b45 Branch : main Author : davecash75 <[email protected]> Time : 2024-09-04 13:55:52 +0000 Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper 1 switch to carpentriessandpaper
Auto-generated via `{sandpaper}` Source : e044bf6 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-11-12 00:15:48 +0000 Message : markdown source builds Auto-generated via `{sandpaper}` Source : c956b45 Branch : main Author : davecash75 <[email protected]> Time : 2024-09-04 13:55:52 +0000 Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper 1 switch to carpentriessandpaper
Auto-generated via `{sandpaper}` Source : c956b45 Branch : main Author : davecash75 <[email protected]> Time : 2024-09-04 13:55:52 +0000 Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper 1 switch to carpentriessandpaper
Auto-generated via `{sandpaper}` Source : ddde3f2 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-11-19 00:17:30 +0000 Message : markdown source builds Auto-generated via `{sandpaper}` Source : c956b45 Branch : main Author : davecash75 <[email protected]> Time : 2024-09-04 13:55:52 +0000 Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper 1 switch to carpentriessandpaper
Auto-generated via `{sandpaper}` Source : c956b45 Branch : main Author : davecash75 <[email protected]> Time : 2024-09-04 13:55:52 +0000 Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper 1 switch to carpentriessandpaper
Auto-generated via `{sandpaper}` Source : 2b4f2d8 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-11-26 00:16:58 +0000 Message : markdown source builds Auto-generated via `{sandpaper}` Source : c956b45 Branch : main Author : davecash75 <[email protected]> Time : 2024-09-04 13:55:52 +0000 Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper 1 switch to carpentriessandpaper
Auto-generated via `{sandpaper}` Source : c956b45 Branch : main Author : davecash75 <[email protected]> Time : 2024-09-04 13:55:52 +0000 Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper 1 switch to carpentriessandpaper
Auto-generated via `{sandpaper}` Source : 3acf55a Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-12-03 00:18:32 +0000 Message : markdown source builds Auto-generated via `{sandpaper}` Source : c956b45 Branch : main Author : davecash75 <[email protected]> Time : 2024-09-04 13:55:52 +0000 Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper 1 switch to carpentriessandpaper
Auto-generated via `{sandpaper}` Source : c956b45 Branch : main Author : davecash75 <[email protected]> Time : 2024-09-04 13:55:52 +0000 Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper 1 switch to carpentriessandpaper
Auto-generated via `{sandpaper}` Source : db5a5d4 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-12-10 00:17:55 +0000 Message : markdown source builds Auto-generated via `{sandpaper}` Source : c956b45 Branch : main Author : davecash75 <[email protected]> Time : 2024-09-04 13:55:52 +0000 Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper 1 switch to carpentriessandpaper
Auto-generated via `{sandpaper}` Source : c956b45 Branch : main Author : davecash75 <[email protected]> Time : 2024-09-04 13:55:52 +0000 Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper 1 switch to carpentriessandpaper
Auto-generated via `{sandpaper}` Source : 9ea4a9a Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-12-17 00:17:34 +0000 Message : markdown source builds Auto-generated via `{sandpaper}` Source : c956b45 Branch : main Author : davecash75 <[email protected]> Time : 2024-09-04 13:55:52 +0000 Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper 1 switch to carpentriessandpaper
Auto-generated via `{sandpaper}` Source : c956b45 Branch : main Author : davecash75 <[email protected]> Time : 2024-09-04 13:55:52 +0000 Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper 1 switch to carpentriessandpaper
Auto-generated via `{sandpaper}` Source : 89d7b29 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-12-24 00:15:59 +0000 Message : markdown source builds Auto-generated via `{sandpaper}` Source : c956b45 Branch : main Author : davecash75 <[email protected]> Time : 2024-09-04 13:55:52 +0000 Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper 1 switch to carpentriessandpaper
Auto-generated via `{sandpaper}` Source : c956b45 Branch : main Author : davecash75 <[email protected]> Time : 2024-09-04 13:55:52 +0000 Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper 1 switch to carpentriessandpaper
Auto-generated via `{sandpaper}` Source : 72f637a Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-12-31 00:15:58 +0000 Message : markdown source builds Auto-generated via `{sandpaper}` Source : c956b45 Branch : main Author : davecash75 <[email protected]> Time : 2024-09-04 13:55:52 +0000 Message : Merge pull request #22 from HealthBioscienceIDEAS/1-switch-to-carpentriessandpaper 1 switch to carpentriessandpaper
Description
Fixes #1: Now that sandpaper change has been implemented, I have adjusted not only the config.yaml file as @milanmlft suggested, but also the setting up instructions, which included a lot of how the repository
was originally created. Since that has already been done, new users won't have to do that anymore.
Type of change
Suggested Checklist
CONTRIBUTING
docspre-commit run -a
pytest -sv tests
rebase
is need.