Test regexp_matched_num PR #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay, so that ...Can we skip neko part for |
|
The code changed slightly when porting to pcre2. I can try to fix it because it wasn't too long ago when I ported it. |
tobil4sk
reviewed
Mar 4, 2022
libs/regexp/regexp.c
Outdated
| @@ -311,7 +311,7 @@ static value regexp_matched_num( value o ) { | |||
| d = PCRE(o); | |||
| if( val_is_null(d->str) ) | |||
| return alloc_int(-1); | |||
| return alloc_int(d->nmatches); | |||
| return alloc_int(d->nmatchs); | |||
There was a problem hiding this comment.
I renamed this field to n_groups while porting because I found it confusing (and because of the typo). Changing this from nmatchs to n_groups should be the fix.
tobil4sk
reviewed
Jan 29, 2023
|
@Simn can this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Want to see green #223
Closes #223