Get size of map and regex captures

[ALANVF]

Part 2 of an effort to add methods to get the size of a map, and the number of captures from a regex.

There are other ways I could implement the size method for Hashes, so I can do it another way if you don't like my current implementation.

Option 1

The current solution, which is to cast the XXXHashBase * value to XXXHashObject * and access getSize that way.

int __XXX_hash_size(Dynamic &ioHash) {
    XXXHashBase *hash = static_cast<XXXHashBase *>(ioHash.GetPtr());
    if(!hash)
       return 0;
    return ((XXXHashObject *) hash)->getSize();
}

Option 2

Add HashBase#getSize() as a virtual method, and remove the inline qualifier from the Hash#getSize() method.

class HashBase ... {
    ...
    virtual int getSize() = 0;
};

class Hash ... {
    ...
    int getSize() { return size; }
};

Option 3

Instead of making getSize a virtual method, add a variant of it that is virtual instead (that way it doesn't affectexisting code).

class HashBase ... {
    ...
    virtual int getDynSize() = 0;
};

class Hash ... {
    ...
    int getDynSize() { return size; }
};

Option 4

Move the size property from Hash to HashBase, and then move getSize from Hash to HashBase so that it can remain inline.

class HashBase ... {
    int size;
    ...
    inline int getSize() { return size; }
};

class Hash ... {
    ...
};

Part 1: HaxeFoundation/hashlink#437

[hughsando]

I think option 1/4 can work. There is already "struct HashRoot" which can form this base class.
The "size" member can be moved into this struct (so could "mask" and "bucketCount")
The dynamic hash could then be static-cast to HashRoot and you would not need a separate function for each type.

[ALANVF]

Status?

[hughsando]

Looks good, but can you remove the unused type-specific size functions from the header?
Also, the base variables can be exposed in the derived class with using HashRoot::size etc in the Hash class, rather than with the this-> notation.

[ALANVF]

Fixed 👍

[hughsando]

Brilliant! Thanks a lot.