-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor client code and extract repository/library methods into new modules #510
Commits on Apr 4, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 286512a - Browse repository at this point
Copy the full SHA 286512aView commit details -
- Move IS_WINDOWS - Remove extra absolutePath implementation
Configuration menu - View commit details
-
Copy full SHA for b3c8308 - Browse repository at this point
Copy the full SHA b3c8308View commit details -
Extract repo management methods to new module
Make minor refactor of `setup` command code
Configuration menu - View commit details
-
Copy full SHA for 5be6aa7 - Browse repository at this point
Copy the full SHA 5be6aa7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b1d4b0 - Browse repository at this point
Copy the full SHA 7b1d4b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7839122 - Browse repository at this point
Copy the full SHA 7839122View commit details -
Configuration menu - View commit details
-
Copy full SHA for 77e8c5b - Browse repository at this point
Copy the full SHA 77e8c5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for a83d3c9 - Browse repository at this point
Copy the full SHA a83d3c9View commit details -
Refactor client initialization
- Set all members of the client main class in the constructor. - Do not store settings that are not necessary outside the constructor. - Do not initialize site multiple times in some cases - Consider --debug and --quiet mutually exclusive - Print switch information in an ordered way - Do not run any code until it is known that the call is not being passed on to the updated haxelib version - Fix -cwd not working when redirecting to haxelib version - Separate command functionality from docs
Configuration menu - View commit details
-
Copy full SHA for 891a183 - Browse repository at this point
Copy the full SHA 891a183View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3fcdce9 - Browse repository at this point
Copy the full SHA 3fcdce9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 592f0d5 - Browse repository at this point
Copy the full SHA 592f0d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ca47ec - Browse repository at this point
Copy the full SHA 6ca47ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for bfd2563 - Browse repository at this point
Copy the full SHA bfd2563View commit details -
- Fix specifying a version not working if a development directory is set - Show an error if a non-existent version is specified instead of silently using a different version - Reset environment variables and current working directory after a run so that it is safe to use as a function in a process
Configuration menu - View commit details
-
Copy full SHA for 29496d5 - Browse repository at this point
Copy the full SHA 29496d5View commit details -
Refactor code for
path
andlibpath
commands- Show error if a non-existent library version is specified with either command, instead of silently using a different version, as now with the `run` command - If two versions of the same library are given to path, the error mentions them in the order they appeared
Configuration menu - View commit details
-
Copy full SHA for f6922cb - Browse repository at this point
Copy the full SHA f6922cbView commit details -
- Fix minor issue with alphabetical ordering - Before, they were sorted by `name:` instead of `name`, so for example `flixel` came after `flixel-addons`, which was incorrect - Do not list invalid versions
Configuration menu - View commit details
-
Copy full SHA for 329aa19 - Browse repository at this point
Copy the full SHA 329aa19View commit details -
Refactor the way settings are used by Cli and Vcs
Remove no longer relevant TODO messages
Configuration menu - View commit details
-
Copy full SHA for 42939db - Browse repository at this point
Copy the full SHA 42939dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ece648 - Browse repository at this point
Copy the full SHA 1ece648View commit details -
Configuration menu - View commit details
-
Copy full SHA for 76c7969 - Browse repository at this point
Copy the full SHA 76c7969View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ae5b17 - Browse repository at this point
Copy the full SHA 6ae5b17View commit details -
Rework install, set and update
- Check for hashlink c target when searching hxml for dependencies - Fix installing from `haxelib.json` with `--skip-dependencies` doing nothing - Previously, installing from a `haxelib.json` file was seen as installing dependencies, so with `--skip-dependencies` the command would do nothing. Now, with the flag, the libraries in the file are not skipped, however their dependencies still are. - Don't update vcs version if it is not set as current version HaxeFoundation#364 - Decouple cli from installation code - Disallow setting invalid library versions with `set`
Configuration menu - View commit details
-
Copy full SHA for d936318 - Browse repository at this point
Copy the full SHA d936318View commit details -
Add workarounds for capitalisation inconsistencies
- Fix error when installing from hxml due to capitalisation
Configuration menu - View commit details
-
Copy full SHA for fcdc5f0 - Browse repository at this point
Copy the full SHA fcdc5f0View commit details -
[docs] Update site documentation in line with changes
- Use two dashes for `--notimeout` and `--cwd` - Update information on run version resolution
Configuration menu - View commit details
-
Copy full SHA for 5985747 - Browse repository at this point
Copy the full SHA 5985747View commit details -
Refactor code for
remove
command- Fix issue where it was possible to remove a git/hg version even if a development path was set within it
Configuration menu - View commit details
-
Copy full SHA for 0e54121 - Browse repository at this point
Copy the full SHA 0e54121View commit details -
- Don't show updated message if vcs dependency was already up to date - Clean up debug logs of git/hg output
Configuration menu - View commit details
-
Copy full SHA for 59ad81d - Browse repository at this point
Copy the full SHA 59ad81dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 38d9fc8 - Browse repository at this point
Copy the full SHA 38d9fc8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b54818 - Browse repository at this point
Copy the full SHA 8b54818View commit details -
Configuration menu - View commit details
-
Copy full SHA for a717174 - Browse repository at this point
Copy the full SHA a717174View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3125c6a - Browse repository at this point
Copy the full SHA 3125c6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for cf3abe1 - Browse repository at this point
Copy the full SHA cf3abe1View commit details -
Move reusable modules into
api
packageTo achieve separation of the haxelib cli from the general code that can be reused.
Configuration menu - View commit details
-
Copy full SHA for 5e55d6a - Browse repository at this point
Copy the full SHA 5e55d6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8daba0b - Browse repository at this point
Copy the full SHA 8daba0bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 77aec45 - Browse repository at this point
Copy the full SHA 77aec45View commit details -
Configuration menu - View commit details
-
Copy full SHA for f60904b - Browse repository at this point
Copy the full SHA f60904bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f0ee079 - Browse repository at this point
Copy the full SHA f0ee079View commit details -
Fix
run
with older versions of haxeVersions prior to haxe 4 don't recognise `--version` and print their version to stderr instead of stdout
Configuration menu - View commit details
-
Copy full SHA for 712afce - Browse repository at this point
Copy the full SHA 712afceView commit details -
Remember capitalisation of library when installed
Addresses HaxeFoundation#529 This way, list shows the correct version of the name, and path falls back to the correct version when no haxelib.json is found. The "correct" version is the way the name in haxelib.json is capitalized, or if no such file exists it is the way the parameter to the `dev`/`git`/`hg` command was capitalized. Additionally, if the parameter is an alias, then it is used instead as well. It is updated everytime a version is set as current. However, officially released library version names are preferred over the capitalization of `dev`, `git`, or `hg` versions. For example, after: `haxelib dev LIBRARY <path>` `haxelib install library 1.0.0` If `library` is the version in `haxelib.json`, then that is preferred over `LIBRARY` after we install from the server. Throw error in `path` command when two versions of the same lib are queried even if the two versions are capitalized differently. - e.g. `LiBrArY:1.2.0` and `library:1.3.0` Ensure that haxelib run sets HAXELIB_RUN_NAME to name field in `haxelib.json`. Ignore capitalized directories in `list`.
Configuration menu - View commit details
-
Copy full SHA for 6969dda - Browse repository at this point
Copy the full SHA 6969ddaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8cc06fa - Browse repository at this point
Copy the full SHA 8cc06faView commit details -
[tests] Adding testing for HaxeFoundation#529
Also HaxeFoundation#465 and HaxeFoundation#503 - Ensure haxelib is case insensitive for library names - Ensure haxelib keeps track of correct name capitalization for `list` command - Ensure haxelib.json name is preferred with git/hg/dev, unless an alias is given. - If there is no haxelib.json, ensure that the last name the user used is shown - Ensure running aliased libraries works correctly
Configuration menu - View commit details
-
Copy full SHA for a8b3520 - Browse repository at this point
Copy the full SHA a8b3520View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e95b82 - Browse repository at this point
Copy the full SHA 6e95b82View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee9e75e - Browse repository at this point
Copy the full SHA ee9e75eView commit details -
[tests] Add more testing for remove command
For removing specific versions
Configuration menu - View commit details
-
Copy full SHA for 488b96a - Browse repository at this point
Copy the full SHA 488b96aView commit details -
[tests] Add tests for multiple issues
- HaxeFoundation#364 - HaxeFoundation#526 - Ensure `list` doesn't break with invalid directories in the repository - Ensure `list` doesn't show invalid versions - Ensure --skip-dependencies doesn't break installing from haxelib.json - Ensure --cwd works - Ensure specifying versions with run, path, and libpath commands works properly HaxeFoundation#249 - Don't show update message if vcs lib was already up to date - Ensure order of output of `path` is correct - Ensure remove can't break dev path set inside git/hg version
Configuration menu - View commit details
-
Copy full SHA for a936899 - Browse repository at this point
Copy the full SHA a936899View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0df427c - Browse repository at this point
Copy the full SHA 0df427cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e7147a9 - Browse repository at this point
Copy the full SHA e7147a9View commit details -
Implement repository reformatting using
fixrepo
For breaking changes such as the library name case insensitivity change Show warning for every command using the repository if it is out of date
Configuration menu - View commit details
-
Copy full SHA for 21f07bc - Browse repository at this point
Copy the full SHA 21f07bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3935fae - Browse repository at this point
Copy the full SHA 3935faeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 82c1c02 - Browse repository at this point
Copy the full SHA 82c1c02View commit details -
Fix error to display library name correctly
`haxelib path` now repeats the version of the name the user typed in if the library is not installed, instead of making it lowercase
Configuration menu - View commit details
-
Copy full SHA for 53ee4ba - Browse repository at this point
Copy the full SHA 53ee4baView commit details -
Configuration menu - View commit details
-
Copy full SHA for b94ba75 - Browse repository at this point
Copy the full SHA b94ba75View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed7c0ef - Browse repository at this point
Copy the full SHA ed7c0efView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5bba820 - Browse repository at this point
Copy the full SHA 5bba820View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1939584 - Browse repository at this point
Copy the full SHA 1939584View commit details -
Configuration menu - View commit details
-
Copy full SHA for 46323b1 - Browse repository at this point
Copy the full SHA 46323b1View commit details -
[tests] Set git user data in integration test repo
Show error output in case git commands fail to make stuff like this easier to debug.
Configuration menu - View commit details
-
Copy full SHA for 1d5606b - Browse repository at this point
Copy the full SHA 1d5606bView commit details -
[tests] Fix constructor issue for haxe non-nightly
Not initialising the field in the abstract class constructor results in a compiler error in non nightly builds of haxe
Configuration menu - View commit details
-
Copy full SHA for 64f00f8 - Browse repository at this point
Copy the full SHA 64f00f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4fc20fa - Browse repository at this point
Copy the full SHA 4fc20faView commit details -
Make reformatting more predictable
Do not depend on how the system sorts child files/directories
Configuration menu - View commit details
-
Copy full SHA for f60ea15 - Browse repository at this point
Copy the full SHA f60ea15View commit details -
Sort the correct array this time
We don't need to sort on Windows as it has a case insensitive file system, so we won't get clashes.
Configuration menu - View commit details
-
Copy full SHA for acb1634 - Browse repository at this point
Copy the full SHA acb1634View commit details
Commits on Apr 5, 2022
-
Install hxjava for --jvm target in hxml install
Generate the regex from TARGETS to avoid repetition
Configuration menu - View commit details
-
Copy full SHA for 7e4f8da - Browse repository at this point
Copy the full SHA 7e4f8daView commit details -
Remove .c check for hashlink library
`-D run` requires hashlink library to be installed even for bytecode compilation.
Configuration menu - View commit details
-
Copy full SHA for 612c642 - Browse repository at this point
Copy the full SHA 612c642View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8891ff6 - Browse repository at this point
Copy the full SHA 8891ff6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d1231b - Browse repository at this point
Copy the full SHA 7d1231bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 459c3c8 - Browse repository at this point
Copy the full SHA 459c3c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for cac1fae - Browse repository at this point
Copy the full SHA cac1faeView commit details -
Configuration menu - View commit details
-
Copy full SHA for ffbebc9 - Browse repository at this point
Copy the full SHA ffbebc9View commit details -
Remove Installer.installLatestFromHaxelib
It is now combined with installFromHaxelib, whose version argument is now optional.
Configuration menu - View commit details
-
Copy full SHA for 38b0916 - Browse repository at this point
Copy the full SHA 38b0916View commit details -
Minor cleanup of install command code
No need to check if the requested version matches the scope version, as if that were the case it would have been caught in the check above.
Configuration menu - View commit details
-
Copy full SHA for 677f9d9 - Browse repository at this point
Copy the full SHA 677f9d9View commit details -
Fix installFromHxml on already installed libraries
Prevent reinstalling existing libraries
Configuration menu - View commit details
-
Copy full SHA for 18dbbb4 - Browse repository at this point
Copy the full SHA 18dbbb4View commit details -
Set all library versions when installing from hxml
Reverting to previous behaviour
Configuration menu - View commit details
-
Copy full SHA for 1ad8f0b - Browse repository at this point
Copy the full SHA 1ad8f0bView commit details