Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"haxe" define #8305

Merged
merged 8 commits into from
May 24, 2019
Merged

"haxe" define #8305

merged 8 commits into from
May 24, 2019

Conversation

RealyUniqueName
Copy link
Member

Closes #8302

#if (haxe >= version("4.0.0"))
trace("Haxe 4.0.0 or higher");
#end

@RealyUniqueName RealyUniqueName added this to the Release 4.0 milestone May 19, 2019
@RealyUniqueName RealyUniqueName requested a review from ncannasse May 19, 2019 11:53
@Gama11
Copy link
Member

Gama11 commented May 19, 2019

Should probably also be added to reserved_flags in main (haxe_ver too)?

@skial skial mentioned this pull request May 20, 2019
Closed
1 task
@Simn
Copy link
Member

Simn commented May 23, 2019

Can we use s_version without the build suffix for this? I would like to avoid duplicating this code.

@RealyUniqueName RealyUniqueName merged commit 9213adb into HaxeFoundation:development May 24, 2019
@Gama11 Gama11 mentioned this pull request May 28, 2019
Merged
@nanjizal nanjizal mentioned this pull request Jul 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncannasse ncannasse Awaiting requested review from ncannasse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 4.0
Development

Successfully merging this pull request may close these issues.

haxe_ver format
3 participants
@RealyUniqueName @Gama11 @Simn