-
-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More strict macro API for init vs non init macros #11043
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simn
reviewed
Mar 28, 2023
Simn
reviewed
Mar 28, 2023
(waiting for #11046 before running CI again) |
kLabz
force-pushed
the
feature/strict-init-macros
branch
from
March 28, 2023 08:06
cbbeaa7
to
ffa5d46
Compare
CI failures are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a first step towards #7871, adds:
Context.onAfterInitMacros
to register typer-related code from init macros to be run once typer is readyContext.initMacrosDone
to check if configuration phase is over-D haxe-next
for now, about code currently run from init macros that should be delayed usingContext.onAfterInitMacros
Also adds
Context.getMacroStack()
to get a call stack ofhaxe.macro.Position
for code running in macro context. Useful for custom message reporting.Closes #11039