Added API to haxe.Http for multiple response headers with same name. #10812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bump |
|
This looks pretty awkward, but I don't really know how else to handle this situation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As was reported here (#3550) there are situations when an endpoint returns multiple response headers with the same name (e.g.
Set-Cookie) and these headers (except the last one) became unreachable.So this PR adds a new method
getResponseHeaderValues(suggested by @RealyUniqueName from #9053 (comment)) to a public API of thehaxe.Httpclass.This implementation of the method is trying to avoid an overhead allocation when it is possible: if an endpoint returns only single headers then
responseHeadersSameKeywill not be allocated and will keep anullstate.If you have any suggestions or remarks I would be happy to update my commit.