Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Context.makeMonomorph #10728

Merged
merged 2 commits into from
Jun 13, 2022
Merged

add Context.makeMonomorph #10728

merged 2 commits into from
Jun 13, 2022

Conversation

nadako
Copy link
Member

@nadako nadako commented Jun 12, 2022

No description provided.

@Simn
Copy link
Member

Simn commented Jun 13, 2022

The only thing I'm not sure about is if it should be make or create. I feel like we tend to use the latter more often.

@nadako
Copy link
Member Author

nadako commented Jun 13, 2022

In haxe.macro.Context we don't have create* methods, but we do have makeExpr and makePosition, that's why I named it like that.

@Simn Simn merged commit b0d9152 into development Jun 13, 2022
@nadako nadako deleted the macro_make_monomorph branch June 13, 2022 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nadako @Simn