Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move haxelib to higher level #10654

Merged
merged 2 commits into from
Mar 30, 2022

Conversation

Simn
Copy link
Member

@Simn Simn commented Mar 30, 2022

Almost forgot about this branch. This moves haxelib handling from the low-level args parsing to the high-level process_params. I also took the opportunity to incorporate some of the changes from #10393.

In theory this should now allow us to provide a different compiler entrypoint.

@Simn
Copy link
Member Author

Simn commented Mar 30, 2022

Oh yeah, I had to add the --neko-lib CLI argument. I realize that this seems pretty silly in 2022, but we have to communicate the special -L handling from haxelib to the lower level somehow. I have no idea if this is actually still used by some haxelibs, but for now I didn't want to risk it.

@skial skial mentioned this pull request Mar 30, 2022
1 task
@Simn Simn merged commit cea8f21 into development Mar 30, 2022
@Simn Simn deleted the haxe.ml_cleanup_2022_part_3_actually_clean branch March 30, 2022 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant