Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've always hated how a
Sys.exit(0)
when running the interpreter would cause an error on the compilation server. This change addresses this by always throwing theSys_exit
exception, but making sure to properly catch it incompiler.ml
.compile_ctx
now returns the exit code, andHighLevel.entry
keeps going (in case of--next
) as long as the exit code is 0. Finally, it callscomm.exit
, which does a legitexit
in the stdio version and nothing in the pipe version (context error state is set bycatch_completion_and_exit
).