Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use property types to infer accessor types #10569

Merged
merged 3 commits into from
Feb 14, 2022

Conversation

Simn
Copy link
Member

@Simn Simn commented Jan 26, 2022

see #10568

I kinda hate how I implemented this, but at least we have a test case now.

@Simn
Copy link
Member Author

Simn commented Jan 26, 2022

There's some null-safety failure:

Code_FU3tVHuAs7

This is now typed as set_str(v:String):String. I think the test relied on v being inferred to Null<String>, but in that case we should just type-hint it directly.

@Simn Simn merged commit add042a into development Feb 14, 2022
@Simn Simn deleted the property_accessor_inference branch February 14, 2022 10:36
@Simn Simn mentioned this pull request Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant