Allow more attributes for generic instances #10557
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh shit, I get to learn new OCaml syntax... :D And thank you for the contribution! |
|
No problem 👍 (also this is by far my favorite ocaml feature, |
|
So, while I appreciate learning new syntax, I think a shorter and faster solution here would be a good old |
|
I don't see that that helps here though, and you'd still probably end up using something similar (just a lot longer) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is hopefully a fix for #10550 and any other related issues.
These are the metadata that are now allowed on generic type instances:
I'm not entirely sure if
usingwill work as intended, but if it doesn't I guess I could change it.I'm also not sure what to do with
autoBuild,build, andgenericBuildso I left them out, and I don't see much use forkeepInitandkeepSub.(I probably missed some metadata, so those can be added if needed)