Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support final doc comment #487

Merged
merged 6 commits into from
Nov 2, 2019

Conversation

AlexHaxe
Copy link
Member

@AlexHaxe AlexHaxe commented Nov 2, 2019

No description provided.

changed reported position for FieldDocComment and MethodLength
renamed InlineFinal to Final
added check for public static to Final check
@codecov
Copy link

codecov bot commented Nov 2, 2019

Codecov Report

❗ No coverage uploaded for pull request base (dev@20e5435). Click here to learn what that means.
The diff coverage is 94.28%.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev     #487   +/-   ##
======================================
  Coverage       ?   97.28%           
======================================
  Files          ?      105           
  Lines          ?     6743           
  Branches       ?      914           
======================================
  Hits           ?     6560           
  Misses         ?      182           
  Partials       ?        1
Impacted Files Coverage Δ
...checkstyle/checks/comments/DocCommentStyleCheck.hx 100% <100%> (ø)
src/checkstyle/checks/size/MethodLengthCheck.hx 100% <100%> (ø)
src/checkstyle/checks/modifier/FinalCheck.hx 96.42% <87.5%> (ø)
...checkstyle/checks/comments/FieldDocCommentCheck.hx 97.7% <96%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20e5435...6f7e38a. Read the comment docs.

@AlexHaxe AlexHaxe force-pushed the support_final_doc_comment branch from bf864ef to 2f15ab6 Compare November 2, 2019 16:31
@AlexHaxe AlexHaxe merged commit c2fc74a into HaxeCheckstyle:dev Nov 2, 2019
@AlexHaxe AlexHaxe deleted the support_final_doc_comment branch November 2, 2019 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant