Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added relax mode to ConfigParser, fixes #441 #443

Merged
merged 2 commits into from
Jun 23, 2018

Conversation

AlexHaxe
Copy link
Member

  • Fixed indentation calculation for functions bodys without curly braces
  • Fixed segmentaion faults in NeedBraces and CatchParameterName checks
  • Changed message of NestedForLoop check

Fixed indentaion calculation for functions bodys without curly braces
Fixed segmentaion faults in NeedBraces and CatchParameterName checks
Changed message of NestedForLoop check
@ghost ghost assigned AlexHaxe Jun 23, 2018
@ghost ghost added the in progress label Jun 23, 2018
@codecov-io
Copy link

codecov-io commented Jun 23, 2018

Codecov Report

Merging #443 into dev will increase coverage by 0.15%.
The diff coverage is 86.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #443      +/-   ##
==========================================
+ Coverage   92.13%   92.29%   +0.15%     
==========================================
  Files          93       93              
  Lines        9173     9201      +28     
  Branches      348      349       +1     
==========================================
+ Hits         8452     8492      +40     
+ Misses        401      388      -13     
- Partials      320      321       +1
Impacted Files Coverage Δ
...rc/checkstyle/checks/coding/NestedForDepthCheck.hx 100% <100%> (ø) ⬆️
src/checkstyle/checks/block/NeedBracesCheck.hx 79.89% <50%> (-0.88%) ⬇️
...heckstyle/checks/naming/CatchParameterNameCheck.hx 97.43% <66.66%> (-2.57%) ⬇️
...c/checkstyle/checks/whitespace/IndentationCheck.hx 96.47% <90%> (-0.17%) ⬇️
src/checkstyle/config/ConfigParser.hx 90.83% <94.44%> (+6.87%) ⬆️
src/checkstyle/ChecksInfo.hx 98.24% <0%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddaa30e...8aa857e. Read the comment docs.

@AlexHaxe AlexHaxe merged commit 0d25b3f into HaxeCheckstyle:dev Jun 23, 2018
@ghost ghost removed the in progress label Jun 23, 2018
@AlexHaxe AlexHaxe deleted the relaxe_mode_codeclimate branch June 23, 2018 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants