added more checks to automatic coding style detection

CHANGES.md

@@ -1,7 +1,7 @@
 ## dev branch / next version (2.x.x)
 
 - New command line option `-show-parser-errors` to include parser errors into checkstyle results (default: off) [#413](https://github.com/HaxeCheckstyle/haxe-checkstyle/issues/413)
-- Added more checks for automatic coding style detection [#414](https://github.com/HaxeCheckstyle/haxe-checkstyle/issues/414)
+- Added more checks for automatic coding style detection [#414](https://github.com/HaxeCheckstyle/haxe-checkstyle/issues/414) + [#417](https://github.com/HaxeCheckstyle/haxe-checkstyle/issues/417)
 - Fixed handling of `Arrow` in type names in TokenTree [#413](https://github.com/HaxeCheckstyle/haxe-checkstyle/issues/413)
 - Fixed handling of `Dot` after `KwdNew` in TokenTree [#413](https://github.com/HaxeCheckstyle/haxe-checkstyle/issues/413)
 - Fixed line number reported for MethodCount check [#415](https://github.com/HaxeCheckstyle/haxe-checkstyle/issues/415)

src/checkstyle/checks/coding/HiddenFieldCheck.hx

@@ -128,4 +128,18 @@ class HiddenFieldCheck extends Check {
 		}
 		return memberNames;
 	}
+
+	override public function detectableInstances():DetectableInstances {
+		return [{
+			fixed: [],
+			properties: [{
+				propertyName: "ignoreConstructorParameter",
+				values: [true, false]
+			},
+			{
+				propertyName: "ignoreSetter",
+				values: [true, false]
+			}]
+		}];
+	}
 }

src/checkstyle/checks/coding/InnerAssignmentCheck.hx

@@ -105,4 +105,14 @@ class InnerAssignmentCheck extends Check {
 
 		return false;
 	}
+
+	override public function detectableInstances():DetectableInstances {
+		return [{
+			fixed: [],
+			properties: [{
+				propertyName: "ignoreReturnAssignments",
+				values: [false, true]
+			}]
+		}];
+	}
 }

src/checkstyle/checks/coding/NestedForDepthCheck.hx

@@ -51,4 +51,14 @@ class NestedForDepthCheck extends Check {
 	function warnNestedForDepth(depth:Int, pos:Position) {
 		logPos('Nested for depth is $depth (max allowed is ${max})', pos);
 	}
+
+	override public function detectableInstances():DetectableInstances {
+		return [{
+			fixed: [],
+			properties: [{
+				propertyName: "max",
+				values: [for (i in 1...5) i]
+			}]
+		}];
+	}
 }

src/checkstyle/checks/coding/NestedIfDepthCheck.hx

@@ -50,4 +50,14 @@ class NestedIfDepthCheck extends Check {
 	function warnNestedIfDepth(depth:Int, pos:Position) {
 		logPos('Nested if-else depth is $depth (max allowed is ${max})', pos);
 	}
+
+	override public function detectableInstances():DetectableInstances {
+		return [{
+			fixed: [],
+			properties: [{
+				propertyName: "max",
+				values: [for (i in 1...10) i]
+			}]
+		}];
+	}
 }

src/checkstyle/checks/coding/NestedTryDepthCheck.hx

@@ -56,4 +56,14 @@ class NestedTryDepthCheck extends Check {
 	function warnNestedTryDepth(depth:Int, pos:Position) {
 		logPos('Nested try depth is $depth (max allowed is ${max})', pos);
 	}
+
+	override public function detectableInstances():DetectableInstances {
+		return [{
+			fixed: [],
+			properties: [{
+				propertyName: "max",
+				values: [for (i in 1...5) i]
+			}]
+		}];
+	}
 }

src/checkstyle/checks/coding/NullableParameterCheck.hx

@@ -39,6 +39,16 @@ class NullableParameterCheck extends Check {
 	function formatArguments(opt:Bool, name:String, nullDefault:Bool):String {
 		return '"' + (opt ? "?" : "") + name + (nullDefault ? " = null" : "") + '"';
 	}
+
+	override public function detectableInstances():DetectableInstances {
+		return [{
+			fixed: [],
+			properties: [{
+				propertyName: "option",
+				values: [QUESTION_MARK, NULL_DEFAULT]
+			}]
+		}];
+	}
 }
 
 @:enum

src/checkstyle/checks/coding/ReturnCountCheck.hx

@@ -45,4 +45,14 @@ class ReturnCountCheck extends Check {
 			default: GO_DEEPER;
 		}
 	}
+
+	override public function detectableInstances():DetectableInstances {
+		return [{
+			fixed: [],
+			properties: [{
+				propertyName: "max",
+				values: [for (i in 2...20) i]
+			}]
+		}];
+	}
 }

src/checkstyle/checks/coding/TraceCheck.hx

@@ -34,7 +34,7 @@ class TraceCheck extends Check {
 			fixed: [],
 			properties: [{
 				propertyName: "severity",
-				values: ["INFO"]
+				values: [SeverityLevel.INFO]
 			}]
 		}];
 	}

src/checkstyle/checks/coding/UnusedLocalVarCheck.hx

@@ -97,4 +97,14 @@ class UnusedLocalVarCheck extends Check {
 		}
 		return GO_DEEPER;
 	}
+
+	override public function detectableInstances():DetectableInstances {
+		return [{
+			fixed: [],
+			properties: [{
+				propertyName: "severity",
+				values: [SeverityLevel.INFO]
+			}]
+		}];
+	}
 }

src/checkstyle/checks/design/EmptyPackageCheck.hx

@@ -26,4 +26,14 @@ class EmptyPackageCheck extends Check {
 			if (firstChild.is(Semicolon)) logRange("Found empty package", entry.pos.min, firstChild.pos.max);
 		}
 	}
+
+	override public function detectableInstances():DetectableInstances {
+		return [{
+			fixed: [],
+			properties: [{
+				propertyName: "enforceEmptyPackage",
+				values: [true, false]
+			}]
+		}];
+	}
 }

src/checkstyle/checks/design/InterfaceCheck.hx

@@ -30,4 +30,18 @@ class InterfaceCheck extends Check {
 			if (!allowProperties && vars.length > 0) logPos("Properties are not allowed in interfaces", intr.pos);
 		}
 	}
+
+	override public function detectableInstances():DetectableInstances {
+		return [{
+			fixed: [],
+			properties: [{
+				propertyName: "allowMarkerInterfaces",
+				values: [true, false]
+			},
+			{
+				propertyName: "allowProperties",
+				values: [true, false]
+			}]
+		}];
+	}
 }

src/checkstyle/checks/design/UnnecessaryConstructorCheck.hx

@@ -53,4 +53,14 @@ class UnnecessaryConstructorCheck extends Check {
 		}
 		return false;
 	}
+
+	override public function detectableInstances():DetectableInstances {
+		return [{
+			fixed: [],
+			properties: [{
+				propertyName: "severity",
+				values: [SeverityLevel.INFO]
+			}]
+		}];
+	}
 }

src/checkstyle/checks/imports/AvoidStarImportCheck.hx

@@ -28,7 +28,7 @@ class AvoidStarImportCheck extends Check {
 			fixed: [],
 			properties: [{
 				propertyName: "severity",
-				values: ["INFO"]
+				values: [SeverityLevel.INFO]
 			}]
 		}];
 	}

src/checkstyle/checks/imports/UnusedImportCheck.hx

@@ -181,4 +181,14 @@ class UnusedImportCheck extends Check {
 		}
 		return typeName == identName;
 	}
+
+	override public function detectableInstances():DetectableInstances {
+		return [{
+			fixed: [],
+			properties: [{
+				propertyName: "severity",
+				values: [SeverityLevel.INFO]
+			}]
+		}];
+	}
 }

src/checkstyle/checks/type/AnonymousCheck.hx

@@ -50,7 +50,7 @@ class AnonymousCheck extends Check {
 			fixed: [],
 			properties: [{
 				propertyName: "severity",
-				values: ["INFO"]
+				values: [SeverityLevel.INFO]
 			}]
 		}];
 	}

src/checkstyle/checks/type/DynamicCheck.hx

@@ -35,7 +35,7 @@ class DynamicCheck extends Check {
 			fixed: [],
 			properties: [{
 				propertyName: "severity",
-				values: ["INFO"]
+				values: [SeverityLevel.INFO]
 			}]
 		}];
 	}

src/checkstyle/checks/type/TypeCheck.hx

@@ -33,7 +33,7 @@ class TypeCheck extends Check {
 			fixed: [],
 			properties: [{
 				propertyName: "severity",
-				values: ["INFO"]
+				values: [SeverityLevel.INFO]
 			}]
 		}];
 	}

src/checkstyle/detect/DetectCodingStyle.hx

@@ -5,11 +5,13 @@ import checkstyle.Checker;
 import checkstyle.checks.Check;
 import checkstyle.utils.ConfigUtils;
 import checkstyle.reporter.ReporterManager;
+import haxe.ds.ArraySort;
 
 class DetectCodingStyle {
 
 	public static function detectCodingStyle(checks:Array<Check>, fileList:Array<CheckFile>):Array<CheckConfig> {
 		var detectedChecks:Array<CheckConfig> = [];
+		ArraySort.sort(checks, ConfigUtils.checkSort);
 		for (check in checks) detectCheck(check, detectedChecks, fileList);
 
 		return detectedChecks;

src/checkstyle/utils/ConfigUtils.hx

@@ -42,12 +42,18 @@ class ConfigUtils {
 		file.close();
 	}
 
-	public  static function checkConfigSort(a:CheckConfig, b:CheckConfig):Int {
+	public static function checkConfigSort(a:CheckConfig, b:CheckConfig):Int {
 		if (a.type == b.type) return 0;
 		if (a.type < b.type) return -1;
 		return 1;
 	}
 
+	public static function checkSort(a:Check, b:Check):Int {
+		if (a.getModuleName() == b.getModuleName()) return 0;
+		if (a.getModuleName() < b.getModuleName()) return -1;
+		return 1;
+	}
+
 	public static function makeCheckConfig(check:Check):CheckConfig {
 		var propsNotAllowed:Array<String> = [
 			"moduleName", "severity", "type", "categories",