Fix false positive with EmptyLinesCheck. #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic incorrectly skipped over lines that had single-line comments filling the entire line. Fixed issue and updated unit tests to prevent regression.
Gama11
reviewed
Nov 7, 2016
| @@ -38,7 +38,14 @@ class EmptyLinesCheck extends LineCheckBase { | |||
| for (i in 0...checker.lines.length) { | |||
| var line = checker.lines[i]; | |||
| var ranges = getRanges(line); | |||
| if (ranges.length == 1 && ranges[0].type != TEXT) continue; | |||
| //if (ranges.length == 1 && ranges[0].type != TEXT) continue; | |||
There was a problem hiding this comment.
Why leave the old logic in, but commented out?
There was a problem hiding this comment.
Because I'm a dumb dumb.
Current coverage is 89.62% (diff: 100%)@@ dev #310 diff @@
==========================================
Files 115 115
Lines 7601 7607 +6
Methods 0 0
Messages 0 0
Branches 293 293
==========================================
+ Hits 6812 6818 +6
Misses 529 529
Partials 260 260
|
|
That was a quick fix. Looking good in Flixel now, the one EmptyLinesCheck warning left over is actually not a false positive. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic incorrectly skipped over lines that had single-line comments filling the entire line. Fixed issue and updated unit tests to prevent regression.