Exclude #142
Merged
Exclude #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,7 +15,7 @@ class TabForAligningCheck extends Check { | |||
| for (i in 0 ... checker.lines.length) { | |||
| var line = checker.lines[i]; | |||
| if (re.match(line) && !line.contains("//")) { | |||
| log("Tab after non-space character. Use space for aligning", i + 1, line.length); | |||
| log("Tab after non-space character, Use space for aligning", i + 1, line.length); | |||
|
Refactor in progress and will address any issues like this in another PR. Keep posting. |
| @@ -0,0 +1,62 @@ | |||
| { | |||
There was a problem hiding this comment.
Very nice to have these in a separated file now! 👍
There was a problem hiding this comment.
I really enjoyed removing all the @SuppressWarnings in code 😄
There was a problem hiding this comment.
They're all class-wide now though (for now at least?).
There was a problem hiding this comment.
yes.. for now.. need to find a way to implement method level exclude.
There was a problem hiding this comment.
You mean field level? (for variables and properties it should be possible as well)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
packageandclasslevel exclude functionality SuppressWarnings flexibility #120I still have some changes locally so any feedback/issues, let me know instead of updating the code pls.