Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't ignore all in default config #284

Closed
skwerlman opened this issue Sep 3, 2016 · 2 comments
Closed

Don't ignore all in default config #284

skwerlman opened this issue Sep 3, 2016 · 2 comments
Assignees

Comments

@skwerlman
Copy link

Running checkstyle with --default-config, I expect it to output a config with the same behavior as running with no config (i.e. default behavior). Instead, it outputs a config with all checks having "severity": "IGNORE".

Setting up a new project is very tedious when i need to scroll through a ~650 line JSON file manually configuring each option...

@adireddy
Copy link
Member

adireddy commented Sep 3, 2016

We definitely discussed about this earlier. We thought this would give an opportunity to enable few checks at a time and set the severity for each check as per users preference.

Generating a config with default behaviour sounds like a good option but that will still mark a few checks with IGNORE and users may not be aware of that.

Another option is to remove severity for each check and just set a global defaultSeverity

@skwerlman
Copy link
Author

That argument against enabling all makes sense.

I think I like the second option you propose more, since it has more or less the same effect, but is a bit less tedious.

@adireddy adireddy self-assigned this Sep 4, 2016
adireddy added a commit that referenced this issue Sep 4, 2016
removed severity for each check in default config, fixes #284
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants