Skip to content

Commit

Permalink
New comment doc checks (#442)
Browse files Browse the repository at this point in the history
* new check FieldDocComment
* fixed Haxe4 coverage reports
  • Loading branch information
AlexHaxe authored Jun 23, 2018
1 parent 8be2cc5 commit ddaa30e
Show file tree
Hide file tree
Showing 16 changed files with 949 additions and 125 deletions.
5 changes: 3 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,11 @@ matrix:
- haxelib git tokentree https://github.com/HaxeCheckstyle/tokentree master src
- haxelib git hxparse https://github.com/simn/hxparse
- haxelib git haxeparser https://github.com/simn/haxeparser
- haxelib git mcover https://github.com/massiveinteractive/mcover master src
- haxelib git mcover https://github.com/AlexHaxe/mcover.git support-eval src
- haxelib git munit https://github.com/AlexHaxe/MassiveUnit.git support-eval src
- haxelib git hxnodejs https://github.com/HaxeFoundation/hxnodejs.git master
- haxelib install mlib
- haxelib install mconsole
- haxelib install compiletime 2.6.0
- haxelib install hxargs 3.0.2
- haxelib install munit
- sed -i 's/:3.3.0//' buildGlobal.hxml
2 changes: 2 additions & 0 deletions CHANGES.md → CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
## dev branch / next version (2.x.x)

- New check DocCommentStyle [#440](https://github.com/HaxeCheckstyle/haxe-checkstyle/issues/440)
- New check FieldDocComment [#442](https://github.com/HaxeCheckstyle/haxe-checkstyle/issues/442)
- New check TypeDocComment [#440](https://github.com/HaxeCheckstyle/haxe-checkstyle/issues/440)
- Fixed handling of comments between types in ExtendedEmptyLines [#440](https://github.com/HaxeCheckstyle/haxe-checkstyle/issues/440)
- Fixed unittest and coverage reporting for Haxe 4 [#442](https://github.com/HaxeCheckstyle/haxe-checkstyle/issues/442)
- Refactored `Checker.getLinePos` to use binary search, reduces runtime from O(N/2) to O(log N) [#439](https://github.com/HaxeCheckstyle/haxe-checkstyle/issues/439)

## version 2.4.1 (2018-06-14)
Expand Down
File renamed without changes.
22 changes: 22 additions & 0 deletions checkstyle.json
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,14 @@
},
"type": "ExtendedEmptyLines"
},
{
"type": "FieldDocComment",
"props": {
"tokens": [
"CLASS_DEF"
]
}
},
{
"props": {
"max": 2000
Expand Down Expand Up @@ -589,6 +597,20 @@
"checks/whitespace/EmptyLinesCheckTest:EmptyLinesCheckTests",
"checks/whitespace/ExtendedEmptyLinesCheckTest:ExtendedEmptyLinesCheckTests"
],
"FieldDocComment": [
"checkstyle/Main",
"checkstyle/Checker",
"checkstyle/ChecksInfo",
"checkstyle/ParserQueue",
"checkstyle/checks/Check",
"config",
"detect",
"errors",
"reporter",
"schema",
"test",
"utils"
],
"LeftCurly": [
"checkstyle/checks/metrics/CyclomaticComplexityCheck"
],
Expand Down
2 changes: 1 addition & 1 deletion gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ function zipIt() {
src: [
"src/**",
"resources/sample-config.json", "resources/logo.png", "resources/codeclimate_pr.png",
"haxelib.json", "run.n", "README.md", "CHANGES.md", "LICENCE.md"
"haxelib.json", "run.n", "README.md", "CHANGELOG.md", "LICENSE.md"
],
dest: "haxe-checkstyle.zip",
compression: "DEFLATE",
Expand Down
6 changes: 2 additions & 4 deletions haxelib.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,8 @@
"AlexHaxe",
"Gama11"
],
"releasenote": "added json schemas for config files; changes and fixes in preparation of vscode-checkstyle - see CHANGES",
"releasenote": "new doc comments checks - see CHANGELOG",
"version": "2.4.1",
"url": "https://github.com/HaxeCheckstyle/haxe-checkstyle",
"dependencies": {

}
"dependencies": {}
}
Loading

0 comments on commit ddaa30e

Please sign in to comment.