rethrow exceptions when running unittests, closes #154 (#242)

refactored unittest for #181

build.hxml

@@ -17,6 +17,7 @@
 
 --next
 -lib mcover:2.1.1
+-D unittest
 -x TestMain
 --macro mcover.MCover.coverage(['checkstyle'], ['src'], ['checkstyle.reporter', 'checkstyle.Main'])
 

checkstyle.json

@@ -518,7 +518,8 @@
 			"checkstyle.Checker",
 			"checkstyle.ChecksInfo",
 			"checkstyle.checks.imports.UnusedImportCheck",
-			"TestMain"
+			"TestMain",
+			"misc.ExtensionsTest"
 		],
 		"MultipleStringLiterals": [
 			"checks",

src/checkstyle/Checker.hx

@@ -125,6 +125,9 @@ class Checker {
 			Sys.println(e);
 			Sys.println("Stacktrace: " + CallStack.toString(CallStack.exceptionStack()));
 			#end
+			#if unittest
+			throw e;
+			#end
 		}
 	}
 
@@ -155,6 +158,9 @@ class Checker {
 			Sys.println(e);
 			Sys.println("Stacktrace: " + CallStack.toString(CallStack.exceptionStack()));
 			#end
+			#if unittest
+			throw e;
+			#end
 		}
 		return null;
 	}

src/checkstyle/checks/Check.hx

@@ -45,6 +45,9 @@ class Check {
 				Sys.println(e);
 				Sys.println("Stacktrace: " + CallStack.toString(CallStack.exceptionStack()));
 				#end
+				#if unittest
+				throw e;
+				#end
 			}
 		}
 		return messages;

src/checkstyle/token/TokenTreeBuilder.hx

@@ -333,7 +333,7 @@ class TokenTreeBuilder {
 		if (stream.is(DblDot)) {
 			var dblDot:TokenTree = stream.consumeTokenDef(DblDot);
 			name.addChild(dblDot);
-			walkTypeNameDef(name);
+			walkTypeNameDef(dblDot);
 		}
 		walkBlock(name);
 	}

test/misc/ExtensionsTest.hx

@@ -6,7 +6,15 @@ import checkstyle.checks.whitespace.IndentationCharacterCheck;
 class ExtensionsTest extends CheckTestCase<ExtensionsTests> {
 
 	public function testExtensions() {
-		assertNoMsg(new IndentationCharacterCheck(), TEST1);
+		try {
+			assertNoMsg(new IndentationCharacterCheck(), TEST1);
+			// unless haxeparse bug is fixed, this code is unreachable
+			assertFalse(true);
+		}
+		catch (e:Dynamic) {
+			assertEquals("misc.ExtensionsTest", e.classname);
+			assertEquals("expected '' but was 'Parsing failed: Unexpected >", e.error.substr(0, 49));
+		}
 	}
 }