Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: State tokens to a serializable array #587

Merged
merged 6 commits into from
Apr 24, 2024

Conversation

tuliomir
Copy link
Collaborator

The next version of Redux throws an error by default whenever there are non-serializable objects in its Store ( more about this on this article ). This PR is one in a series of PRs that aim to refactor all of those instances before the upgrade.

Acceptance Criteria

  • Tokens state on Redux must be serializable

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@tuliomir tuliomir self-assigned this Apr 22, 2024
@tuliomir tuliomir removed the request for review from pedroferreira1 April 22, 2024 16:53
src/reducers/index.js Outdated Show resolved Hide resolved
src/reducers/index.js Outdated Show resolved Hide resolved
src/reducers/index.js Outdated Show resolved Hide resolved
src/sagas/wallet.js Outdated Show resolved Hide resolved
src/sagas/wallet.js Outdated Show resolved Hide resolved
src/utils/helpers.js Outdated Show resolved Hide resolved
src/utils/wallet.js Outdated Show resolved Hide resolved
src/reducers/index.js Outdated Show resolved Hide resolved
src/reducers/index.js Show resolved Hide resolved
src/reducers/index.js Show resolved Hide resolved
@tuliomir tuliomir requested a review from andreabadesso April 24, 2024 12:25
@tuliomir tuliomir merged commit b876fb1 into master Apr 24, 2024
1 check passed
@tuliomir tuliomir deleted the refactor/mutable-state branch April 24, 2024 14:01
@tuliomir tuliomir mentioned this pull request May 3, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants